fix: Various minor type bugs found by Elixir's type checker

Author: atlas-oc

config/runtime.exs

@@ -111,8 +111,6 @@ if config_env() == :prod do
       For example: ecto://USER:PASS@HOST/DATABASE
       """
 
-  maybe_ipv6 = if System.get_env("ECTO_IPV6") in ~w(true 1), do: [:inet6], else: []
-
   config :octocon, :proxy_db, System.get_env("OCTO_PROXY_DB") in ~w(true 1)
 
   config :octocon, Octocon.Repo,

fly.toml

@@ -52,9 +52,15 @@ processes = ['auxiliary', 'sidecar']
 [[vm]]
 memory = '1gb'
 cpu_kind = 'shared'
-cpus = 2
+cpus = 1
 # processes = ['primary', 'auxiliary', 'sidecar']
-processes = ['auxiliary', 'sidecar']
+processes = ['auxiliary']
+
+[[vm]]
+memory = '1gb'
+cpu_kind = 'shared'
+cpus = 2
+processes = ['sidecar']
 
 [[services]]
 internal_port = 41641

lib/octocon/accounts/user.ex

@@ -21,8 +21,6 @@ defmodule Octocon.Accounts.User do
   import Ecto.Changeset
   import Exandra, only: [embedded_type: 3]
 
-  alias Octocon.Accounts.DiscordSettings
-
   @primary_key false
 
   schema "users" do

lib/octocon/alters.ex

@@ -201,10 +201,11 @@ defmodule Octocon.Alters do
     security_level =
       case alter do
         {:ok, alter} -> alter.security_level
-        {:error, :no_alter} -> :private
+        {:error, :no_alter_id} -> :private
+        {:error, :no_alter_alias} -> :private
       end
 
-    if can_view_entity?(friendship_level, security_level) and alter != {:error, :no_alter} do
+    if can_view_entity?(friendship_level, security_level) and alter != {:error, :no_alter_id} and alter != {:error, :no_alter_alias} do
       {:ok, alter} = alter
       fields = get_guarded_fields(user_fields, alter.fields || [], friendship_level)
       {:ok, %{alter | fields: fields}}
@@ -330,7 +331,7 @@ defmodule Octocon.Alters do
         {:error, :database}
     end
   rescue
-    e ->
+    _ ->
       if force_id == nil do
         # Manually resync the user's alter count
         highest_alter_id = get_highest_alter_id({:system, user.id})

lib/octocon/application.ex

@@ -30,7 +30,7 @@ defmodule Octocon.Application do
     Logger.warning("Starting node of type: #{group}")
 
     children =
-      global_children(group) ++
+      global_children() ++
         group_children(group) ++
         [
           # Web endpoint
@@ -50,7 +50,7 @@ defmodule Octocon.Application do
     :ok
   end
 
-  defp global_children(group) do
+  defp global_children() do
     topologies = [
       tailscale: [
         strategy: Cluster.Strategy.Tailscale,

lib/octocon/friendships.ex

@@ -16,10 +16,7 @@ defmodule Octocon.Friendships do
   alias Octocon.Friendships.Friendship
   alias Octocon.Fronts
 
-  alias Octocon.Fronts.{
-    CurrentFront,
-    Front
-  }
+  alias Octocon.Fronts.CurrentFront
 
   @doc """
   Returns the friendship status between two users with the given identities, or `nil` if no friendship exists.
@@ -44,10 +41,14 @@ defmodule Octocon.Friendships do
       )
       |> Repo.one_regional({:user, {:system, friend_id}})
 
-    %{
-      friendship: friendship,
-      friend: friend
-    }
+    if friendship == nil do
+      nil
+    else
+      %{
+        friendship: friendship,
+        friend: friend
+      }
+    end
   end
 
   @doc """
@@ -479,6 +480,9 @@ defmodule Octocon.Friendships do
             {:error, :database}
         end
 
+      Accounts.get_user({:system, Accounts.id_from_system_identity(to_identity, :system)}) == nil ->
+        {:error, :no_user}
+
       true ->
         {:error, :not_requested}
     end
@@ -512,6 +516,9 @@ defmodule Octocon.Friendships do
 
         :ok
 
+      Accounts.get_user({:system, Accounts.id_from_system_identity(to_identity, :system)}) == nil ->
+        {:error, :no_user}
+
       true ->
         {:error, :not_requested}
     end

lib/octocon/fronts.ex

@@ -537,7 +537,7 @@ defmodule Octocon.Fronts do
           )
         end)
 
-        %Front{
+        front = %Front{
           id: id,
           user_id: system_id,
           alter_id: alter_id,
@@ -569,6 +569,8 @@ defmodule Octocon.Fronts do
             Octocon.Global.FrontNotifier.set(system_id, alter_id)
           end)
         end)
+
+        {:ok, front}
     end
   end
 

lib/octocon/fronts/front.ex

@@ -149,7 +149,6 @@ end
 defmodule Octocon.Fronts.FrontByEndTime do
   @moduledoc false
   use Ecto.Schema
-  import Ecto.Changeset
 
   @primary_key false
 

lib/octocon/tags.ex

@@ -422,8 +422,7 @@ defmodule Octocon.Tags do
         {:error, :not_found}
 
       {count, _} when count > 0 ->
-        system_id = Accounts.id_from_system_identity(system_identity, :system)
-
+        # system_id = Accounts.id_from_system_identity(system_identity, :system)
         # spawn(fn ->
         #   OctoconWeb.Endpoint.broadcast!(
         #     "system:#{system_id}",

lib/octocon/workers/simply_plural_import_worker.ex

@@ -20,7 +20,6 @@ defmodule Octocon.Workers.SimplyPluralImportWorker do
   @sp_endpoint URI.parse("https://api.apparyllis.com/v1/")
   @cdn_endpoint URI.parse("https://spaces.apparyllis.com/")
 
-  @impl true
   def perform(%{"system_id" => system_id, "sp_token" => sp_token}) do
     Logger.warning("Performing Simply Plural import for user #{system_id}")