Fixed up removal of unnecessary properties

Author: mcasperson

cmd/internal/converters/deployment_process_converter.go

@@ -121,7 +121,7 @@ func (c DeploymentProcessConverter) toHcl(resource octopus.DeploymentProcess, re
 					Package:                       make([]terraform.TerraformPackage, len(a.Packages)),
 					Condition:                     a.Condition,
 					RunOnServer:                   c.getRunOnServer(a.Properties),
-					Properties:                    c.removeUnnecessaryActionFields(c.replaceIds(c.escapeDollars(sanitizer2.SanitizeMap(a.Properties)), dependencies)),
+					Properties:                    nil,
 					Features:                      c.getFeatures(a.Properties),
 				}
 
@@ -144,7 +144,7 @@ func (c DeploymentProcessConverter) toHcl(resource octopus.DeploymentProcess, re
 
 		for i, s := range resource.Steps {
 			for j, a := range s.Actions {
-				hcl.WriteActionProperties(block, i, j, a.Properties)
+				hcl.WriteActionProperties(block, i, j, c.removeUnnecessaryActionFields(c.replaceIds(c.escapeDollars(sanitizer2.SanitizeMap(a.Properties)), dependencies)))
 			}
 		}
 

cmd/internal/hcl/unquoted_attribute_writer.go

@@ -17,13 +17,13 @@ func WriteUnquotedAttribute(block *hclwrite.Block, attrName string, attrValue st
 
 // WriteActionProperties is used to pretty print the properties of an action, writing a multiline map for the properties,
 // and extracting JSON blobs as maps for easy reading.
-func WriteActionProperties(block *hclwrite.Block, step int, action int, properties map[string]any) {
+func WriteActionProperties(block *hclwrite.Block, step int, action int, properties map[string]string) {
 	block.Body().Blocks()[step].Body().Blocks()[action].Body().SetAttributeTraversal("properties", hcl.Traversal{
 		hcl.TraverseRoot{Name: extractJsonAsMap(properties)},
 	})
 }
 
-func extractJsonAsMap(properties map[string]any) string {
+func extractJsonAsMap(properties map[string]string) string {
 	output := "{"
 
 	for key, value := range properties {