feat(client): allow configuring env via system properties

Author: stainless-app[bot]

README.md

@@ -53,21 +53,23 @@ import org.onebusaway.client.okhttp.OnebusawaySdkOkHttpClient;
 import org.onebusaway.models.currenttime.CurrentTimeRetrieveParams;
 import org.onebusaway.models.currenttime.CurrentTimeRetrieveResponse;
 
-// Configures using the `ONEBUSAWAY_API_KEY` and `ONEBUSAWAY_SDK_BASE_URL` environment variables
+// Configures using the `onebusawaysdk.onebusawayApiKey` and `onebusawaysdk.baseUrl` system properties
+// Or configures using the `ONEBUSAWAY_API_KEY` and `ONEBUSAWAY_SDK_BASE_URL` environment variables
 OnebusawaySdkClient client = OnebusawaySdkOkHttpClient.fromEnv();
 
 CurrentTimeRetrieveResponse currentTime = client.currentTime().retrieve();
 ```
 
 ## Client configuration
 
-Configure the client using environment variables:
+Configure the client using system properties or environment variables:
 
 ```java
 import org.onebusaway.client.OnebusawaySdkClient;
 import org.onebusaway.client.okhttp.OnebusawaySdkOkHttpClient;
 
-// Configures using the `ONEBUSAWAY_API_KEY` and `ONEBUSAWAY_SDK_BASE_URL` environment variables
+// Configures using the `onebusawaysdk.onebusawayApiKey` and `onebusawaysdk.baseUrl` system properties
+// Or configures using the `ONEBUSAWAY_API_KEY` and `ONEBUSAWAY_SDK_BASE_URL` environment variables
 OnebusawaySdkClient client = OnebusawaySdkOkHttpClient.fromEnv();
 ```
 
@@ -89,18 +91,21 @@ import org.onebusaway.client.OnebusawaySdkClient;
 import org.onebusaway.client.okhttp.OnebusawaySdkOkHttpClient;
 
 OnebusawaySdkClient client = OnebusawaySdkOkHttpClient.builder()
-    // Configures using the `ONEBUSAWAY_API_KEY` and `ONEBUSAWAY_SDK_BASE_URL` environment variables
+    // Configures using the `onebusawaysdk.onebusawayApiKey` and `onebusawaysdk.baseUrl` system properties
+    Or configures using the `ONEBUSAWAY_API_KEY` and `ONEBUSAWAY_SDK_BASE_URL` environment variables
     .fromEnv()
     .apiKey("My API Key")
     .build();
 ```
 
 See this table for the available options:
 
-| Setter    | Environment variable      | Required | Default value                             |
-| --------- | ------------------------- | -------- | ----------------------------------------- |
-| `apiKey`  | `ONEBUSAWAY_API_KEY`      | true     | -                                         |
-| `baseUrl` | `ONEBUSAWAY_SDK_BASE_URL` | true     | `"https://api.pugetsound.onebusaway.org"` |
+| Setter    | System property                  | Environment variable      | Required | Default value                             |
+| --------- | -------------------------------- | ------------------------- | -------- | ----------------------------------------- |
+| `apiKey`  | `onebusawaysdk.onebusawayApiKey` | `ONEBUSAWAY_API_KEY`      | true     | -                                         |
+| `baseUrl` | `onebusawaysdk.baseUrl`          | `ONEBUSAWAY_SDK_BASE_URL` | true     | `"https://api.pugetsound.onebusaway.org"` |
+
+System properties take precedence over environment variables.
 
 > [!TIP]
 > Don't create more than one client in the same application. Each client has a connection pool and
@@ -146,7 +151,8 @@ import org.onebusaway.client.okhttp.OnebusawaySdkOkHttpClient;
 import org.onebusaway.models.currenttime.CurrentTimeRetrieveParams;
 import org.onebusaway.models.currenttime.CurrentTimeRetrieveResponse;
 
-// Configures using the `ONEBUSAWAY_API_KEY` and `ONEBUSAWAY_SDK_BASE_URL` environment variables
+// Configures using the `onebusawaysdk.onebusawayApiKey` and `onebusawaysdk.baseUrl` system properties
+// Or configures using the `ONEBUSAWAY_API_KEY` and `ONEBUSAWAY_SDK_BASE_URL` environment variables
 OnebusawaySdkClient client = OnebusawaySdkOkHttpClient.fromEnv();
 
 CompletableFuture<CurrentTimeRetrieveResponse> currentTime = client.async().currentTime().retrieve();
@@ -161,7 +167,8 @@ import org.onebusaway.client.okhttp.OnebusawaySdkOkHttpClientAsync;
 import org.onebusaway.models.currenttime.CurrentTimeRetrieveParams;
 import org.onebusaway.models.currenttime.CurrentTimeRetrieveResponse;
 
-// Configures using the `ONEBUSAWAY_API_KEY` and `ONEBUSAWAY_SDK_BASE_URL` environment variables
+// Configures using the `onebusawaysdk.onebusawayApiKey` and `onebusawaysdk.baseUrl` system properties
+// Or configures using the `ONEBUSAWAY_API_KEY` and `ONEBUSAWAY_SDK_BASE_URL` environment variables
 OnebusawaySdkClientAsync client = OnebusawaySdkOkHttpClientAsync.fromEnv();
 
 CompletableFuture<CurrentTimeRetrieveResponse> currentTime = client.currentTime().retrieve();

onebusaway-sdk-java-core/src/main/kotlin/org/onebusaway/core/ClientOptions.kt

@@ -220,8 +220,12 @@ private constructor(
         fun timeout(): Timeout = timeout
 
         fun fromEnv() = apply {
-            System.getenv("ONEBUSAWAY_SDK_BASE_URL")?.let { baseUrl(it) }
-            System.getenv("ONEBUSAWAY_API_KEY")?.let { apiKey(it) }
+            (System.getProperty("onebusawaysdk.baseUrl")
+                    ?: System.getenv("ONEBUSAWAY_SDK_BASE_URL"))
+                ?.let { baseUrl(it) }
+            (System.getProperty("onebusawaysdk.onebusawayApiKey")
+                    ?: System.getenv("ONEBUSAWAY_API_KEY"))
+                ?.let { apiKey(it) }
         }
 
         /**