Merge pull request #1594 from OneSignal/fix/nserror_localized_description_errors

Fix: Prevent exception when copying an error's localizedDescription

Author: nan-li

iOS_SDK/OneSignalSDK/OneSignalInAppMessages/Controller/OSMessagingController.m

@@ -318,7 +318,7 @@ - (void)attemptFetchWithRetries:(NSString *)subscriptionId
     onFailure:^(OneSignalClientError *error) {
         NSDictionary* responseHeaders = error.responseHeaders;
 
-        [OneSignalLog onesignalLog:ONE_S_LL_VERBOSE message:[NSString stringWithFormat:@"getInAppMessagesFromServer failure: %@", error.underlyingError.localizedDescription]];
+        [OneSignalLog onesignalLog:ONE_S_LL_VERBOSE message:[NSString stringWithFormat:@"getInAppMessagesFromServer failure: %@", error.description]];
 
         if (error.code == 425 || error.code == 429) { // 425 Too Early or 429 Too Many Requests
             NSInteger retryAfter = [responseHeaders[@"Retry-After"] integerValue] ?: DEFAULT_RETRY_AFTER_SECONDS;
@@ -387,7 +387,7 @@ - (void)fetchInAppMessagesWithoutToken:(NSString *)subscriptionId {
             }
         });
     } onFailure:^(OneSignalClientError *error) {
-        [OneSignalLog onesignalLog:ONE_S_LL_VERBOSE message:[NSString stringWithFormat:@"getInAppMessagesFromServer failure: %@", error.underlyingError.localizedDescription]];
+        [OneSignalLog onesignalLog:ONE_S_LL_VERBOSE message:[NSString stringWithFormat:@"getInAppMessagesFromServer failure: %@", error.description]];
     }];
 }
 

iOS_SDK/OneSignalSDK/OneSignalLiveActivities/Source/OneSignalLiveActivitiesManagerImpl.swift

@@ -171,7 +171,7 @@ public class OneSignalLiveActivitiesManagerImpl: NSObject, OSLiveActivities {
                     contentState: contentState,
                     pushType: .token)
         } catch let error {
-            OneSignalLog.onesignalLog(.LL_DEBUG, message: "Cannot start default live activity: " + error.localizedDescription)
+            OneSignalLog.onesignalLog(.LL_DEBUG, message: "Cannot start default live activity: \(error)")
         }
     }