-
Notifications
You must be signed in to change notification settings - Fork 267
Feat: live activities click events #1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nan-li
wants to merge
7
commits into
main
Choose a base branch
from
feat/live_activities_click_events
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Since we cache and retry this request, let's add a timestamp for the original event. This value may or may not be used by the backend, but we can see if there are indeed often delays.
This is the skeleton, we still need to finalize the path and parameters
Add extension method `onesignalWidgetURL` to View and DynamicIsland that is modeled after the corresponding `widgetURL` methods in WidgetKit.
Developers call the `OneSignal.LiveActivities.trackClickAndReturnOriginal(url)` method to provide OneSignal the click tracking metadata. This method returns the intended original URL, with which they use to navigate their users.
c22b068 to
ef32d54
Compare
3f044ac to
2a2d695
Compare
cstyles
reviewed
Oct 17, 2025
| return false | ||
| } | ||
|
|
||
| // TODO: ⚠️ What is the path, method, and parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're reusing pushopen. See this turbine PR: https://github.com/OneSignal/turbine/pull/1628
Nope, we're going to add a new handler to live-activities-http.
Base automatically changed from
feat/live_activities_receive_receipts
to
main
October 20, 2025 20:43
b7f9ec4 to
ef32d54
Compare
notification ID may be nullable if the live activity is started in-app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 Unit tests is WIP
🚧 Documentation is WIP
Description
One Line Summary
Add click events for live activities, which requires considerable client integration.
Details
There are no APIs available to know of click events on a live activity or widget. The workaround implemented is to leverage deep linking and query params to know of a click and the associated live activity data.
Apple documentation:
Motivation
Add analytics for Live Activities
Scope
onesignalWidgetURLmodifier.New APIs:
Widget modifier
The
onesignalWidgetURLsomething something..Click tracking method
The
trackClickAndReturnOriginalsomething something..Testing
Unit testing
🚧 Unit tests is WIP
Manual testing
iPhone 13 on iOS 18.6.2
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is