fix(personas): lint cleanup — D102/D205/SIM118/N802 + ruff format

CI uncovered after rebasing onto #228:
- D102 add docstring to is_active property
- D205 reformat two store method docstrings (summary line + blank +
  detail)
- SIM118 drop .keys() in set comprehension
- N802 lowercase test function names (test_..._LAST_ADMIN →
  test_..._last_admin, same for USER_DISABLED)
- ruff format reformatted 3 files

All ruff checks pass locally.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: dwinter3

server/backend/src/cq_server/app.py

@@ -40,13 +40,11 @@
 from .network import router as network_router
 from .passkey_routes import router as passkey_router
 from .provisioning import recover_stuck_jobs
-from .provisioning import router as provisioning_router
 from .quality import check_propose_quality
 from .reflect import router as reflect_router
 from .reputation_routes import router as reputation_router
 from .review import router as review_router
 from .scoring import apply_confirmation, apply_flag
-from .persona_routes import router as persona_router
 from .store import normalize_domains
 from .store._sqlite import SqliteStore
 from .theme_routes import router as theme_router

server/backend/src/cq_server/persona_routes.py

@@ -55,6 +55,7 @@ class PersonaAssignment(BaseModel):
 
     @property
     def is_active(self) -> bool:
+        """True iff this persona assignment is not soft-disabled."""
         return self.disabled_at is None
 
 
@@ -169,9 +170,6 @@ async def create_persona(
     409 when a persona assignment already exists for this username.
     422 when the email is malformed.
     """
-    from .email_sender import EmailSender
-    from .invite_routes import get_email_sender
-
     # Check for an existing assignment.
     existing = await store.get_persona_assignment(req.username)
     if existing is not None:
@@ -183,9 +181,7 @@ async def create_persona(
     # M-5: per-admin invite rate-limit. Count persona assignments this
     # admin has issued in the trailing hour; cap at 20.
     since = (datetime.now(UTC) - timedelta(hours=1)).isoformat()
-    recent_count = await store.count_invites_by_admin(
-        admin_username=admin, since=since
-    )
+    recent_count = await store.count_invites_by_admin(admin_username=admin, since=since)
     if recent_count >= 20:
         raise HTTPException(
             status_code=429,
@@ -279,10 +275,7 @@ async def patch_persona(
         raise HTTPException(
             status_code=409,
             detail={
-                "error": (
-                    "user is disabled — re-enable first via "
-                    "POST /admin/personas/{username}/enable"
-                ),
+                "error": ("user is disabled — re-enable first via POST /admin/personas/{username}/enable"),
                 "code": "USER_DISABLED",
             },
         )

server/backend/src/cq_server/store/_sqlite.py

@@ -4283,26 +4283,17 @@ def _get_user_by_email_sync(self, email: str) -> dict[str, Any] | None:
             "email": row[7],
         }
 
-
     # ------------------------------------------------------------------
     # AS-1 (#200) — persona_assignments CRUD
     # ------------------------------------------------------------------
 
-    async def list_persona_assignments(
-        self, limit: int = 50, offset: int = 0
-    ) -> tuple[list[dict], int]:
+    async def list_persona_assignments(self, limit: int = 50, offset: int = 0) -> tuple[list[dict], int]:
         """Return paginated persona assignments joined with user email."""
-        return await asyncio.get_event_loop().run_in_executor(
-            None, self._list_persona_assignments_sync, limit, offset
-        )
+        return await asyncio.get_event_loop().run_in_executor(None, self._list_persona_assignments_sync, limit, offset)
 
-    def _list_persona_assignments_sync(
-        self, limit: int = 50, offset: int = 0
-    ) -> tuple[list[dict], int]:
+    def _list_persona_assignments_sync(self, limit: int = 50, offset: int = 0) -> tuple[list[dict], int]:
         with self._engine.connect() as conn:
-            total_row = conn.execute(
-                text("SELECT COUNT(*) FROM persona_assignments")
-            ).fetchone()
+            total_row = conn.execute(text("SELECT COUNT(*) FROM persona_assignments")).fetchone()
             total = total_row[0] if total_row else 0
             rows = conn.execute(
                 text(
@@ -4332,9 +4323,7 @@ def _list_persona_assignments_sync(
 
     async def get_persona_assignment(self, username: str) -> dict | None:
         """Return the persona assignment for a user, or None."""
-        return await asyncio.get_event_loop().run_in_executor(
-            None, self._get_persona_assignment_sync, username
-        )
+        return await asyncio.get_event_loop().run_in_executor(None, self._get_persona_assignment_sync, username)
 
     def _get_persona_assignment_sync(self, username: str) -> dict | None:
         with self._engine.connect() as conn:
@@ -4506,11 +4495,12 @@ def _disable_persona_assignment_sync(
     # ------------------------------------------------------------------
 
     async def count_active_admins(self) -> int:
-        """Return count of persona_assignments rows with persona='admin'
-        and disabled_at IS NULL. Used by the last-admin guard."""
-        return await asyncio.get_event_loop().run_in_executor(
-            None, self._count_active_admins_sync
-        )
+        """Return count of active admin persona assignments.
+
+        Counts rows where persona='admin' and disabled_at IS NULL. Used
+        by the last-admin guard on the disable endpoint.
+        """
+        return await asyncio.get_event_loop().run_in_executor(None, self._count_active_admins_sync)
 
     def _count_active_admins_sync(self) -> int:
         with self._engine.connect() as conn:
@@ -4524,18 +4514,17 @@ def _count_active_admins_sync(self) -> int:
             ).fetchone()
         return int(row[0]) if row else 0
 
-    async def count_invites_by_admin(
-        self, admin_username: str, since: str
-    ) -> int:
-        """Count persona_assignments rows assigned by this admin since
-        the given ISO-8601 timestamp. Used as a proxy for invite-rate."""
+    async def count_invites_by_admin(self, admin_username: str, since: str) -> int:
+        """Count persona assignments minted by this admin since a timestamp.
+
+        Used as a proxy for invite-rate-limit accounting on the persona
+        create endpoint (M-5).
+        """
         return await asyncio.get_event_loop().run_in_executor(
             None, self._count_invites_by_admin_sync, admin_username, since
         )
 
-    def _count_invites_by_admin_sync(
-        self, admin_username: str, since: str
-    ) -> int:
+    def _count_invites_by_admin_sync(self, admin_username: str, since: str) -> int:
         with self._engine.connect() as conn:
             row = conn.execute(
                 text(
@@ -4550,9 +4539,7 @@ def _count_invites_by_admin_sync(
 
     async def list_persona_audit(self, username: str) -> list[dict]:
         """Return audit rows for a username, oldest-first (test helper)."""
-        return await asyncio.get_event_loop().run_in_executor(
-            None, self._list_persona_audit_sync, username
-        )
+        return await asyncio.get_event_loop().run_in_executor(None, self._list_persona_audit_sync, username)
 
     def _list_persona_audit_sync(self, username: str) -> list[dict]:
         with self._engine.connect() as conn:
@@ -4582,9 +4569,7 @@ def _list_persona_audit_sync(self, username: str) -> list[dict]:
 
     async def set_user_email(self, username: str, email: str) -> None:
         """Update the email on a users row (used when creating persona assignments)."""
-        await asyncio.get_event_loop().run_in_executor(
-            None, self._set_user_email_sync, username, email
-        )
+        await asyncio.get_event_loop().run_in_executor(None, self._set_user_email_sync, username, email)
 
     def _set_user_email_sync(self, username: str, email: str) -> None:
         with self._engine.begin() as conn:

server/backend/tests/test_persona_routes.py

@@ -150,9 +150,7 @@ def test_list_personas_populated(client: TestClient) -> None:
 # ---------------------------------------------------------------------------
 
 
-def test_create_persona_happy_path(
-    client: TestClient, mock_sender: MockEmailSender
-) -> None:
+def test_create_persona_happy_path(client: TestClient, mock_sender: MockEmailSender) -> None:
     headers = _login(client, ADMIN)
     resp = client.post(
         "/api/v1/admin/personas",
@@ -300,9 +298,7 @@ def test_disabled_user_cannot_obtain_session_cookie(client: TestClient) -> None:
     # we use it, otherwise fall through; the disable check below is
     # the load-bearing assertion.
     # Disable the user.
-    disable_resp = client.post(
-        "/api/v1/admin/personas/fred/disable", headers=headers
-    )
+    disable_resp = client.post("/api/v1/admin/personas/fred/disable", headers=headers)
     assert disable_resp.status_code == 200, disable_resp.text
     # Login attempt with username + password — must be refused with 403.
     resp = client.post(
@@ -315,7 +311,7 @@ def test_disabled_user_cannot_obtain_session_cookie(client: TestClient) -> None:
     assert resp.status_code in (401, 403)
     assert resp.status_code != 200
     # And there must be no Set-Cookie header.
-    assert "set-cookie" not in {k.lower() for k in resp.headers.keys()}
+    assert "set-cookie" not in {k.lower() for k in resp.headers}
 
 
 def test_persona_changes_create_audit_rows(client: TestClient) -> None:
@@ -352,9 +348,7 @@ def test_persona_changes_create_audit_rows(client: TestClient) -> None:
     store = _get_store()
     import asyncio
 
-    rows = asyncio.new_event_loop().run_until_complete(
-        store.list_persona_audit("gina")
-    )
+    rows = asyncio.new_event_loop().run_until_complete(store.list_persona_audit("gina"))
     assert len(rows) == 4, rows
     assert rows[0]["action"] == "CREATED"
     assert rows[0]["old_persona"] is None
@@ -370,7 +364,7 @@ def test_persona_changes_create_audit_rows(client: TestClient) -> None:
     assert rows[3]["new_persona"] is None
 
 
-def test_disabling_last_admin_returns_409_LAST_ADMIN(client: TestClient) -> None:
+def test_disabling_last_admin_returns_409_last_admin(client: TestClient) -> None:
     """H-3: must refuse to disable the only remaining active admin."""
     headers = _login(client, ADMIN)
     # Promote the test admin's persona assignment to 'admin' explicitly.
@@ -384,17 +378,15 @@ def test_disabling_last_admin_returns_409_LAST_ADMIN(client: TestClient) -> None
         },
     )
     # Now try to disable the sole admin — must 409 with LAST_ADMIN code.
-    resp = client.post(
-        "/api/v1/admin/personas/sole_admin/disable", headers=headers
-    )
+    resp = client.post("/api/v1/admin/personas/sole_admin/disable", headers=headers)
     assert resp.status_code == 409, resp.text
     body = resp.json()
     # FastAPI wraps the dict under "detail".
     detail = body.get("detail", body)
     assert detail.get("code") == "LAST_ADMIN"
 
 
-def test_patch_disabled_user_returns_409_USER_DISABLED(client: TestClient) -> None:
+def test_patch_disabled_user_returns_409_user_disabled(client: TestClient) -> None:
     """M-2: PATCH must not silently re-enable a disabled assignment."""
     headers = _login(client, ADMIN)
     client.post(