Skip to content

Commit f9f5af5

Browse files
authored
[JAVA][FEIGN] Removing hardcoded HTTP Client which is causing performance issues (#21085)
* [JAVA][FEIGN] Removing hardcoded HTTP Client Fixing performance issues * Updating samples for Java Feign performance betterment changes * added APIClient.java for feign-hc5
1 parent 5e446b4 commit f9f5af5

File tree

4 files changed

+0
-18
lines changed

4 files changed

+0
-18
lines changed

modules/openapi-generator/src/main/resources/Java/libraries/feign/ApiClient.mustache

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,6 @@ import java.util.logging.Level;
99
import java.util.logging.Logger;
1010

1111
{{#jackson}}
12-
{{#feign-okhttp}}
13-
import feign.okhttp.OkHttpClient;
14-
{{/feign-okhttp}}
15-
{{#feign-hc5}}
16-
import feign.hc5.ApacheHttp5Client;
17-
{{/feign-hc5}}
1812
import com.fasterxml.jackson.databind.DeserializationFeature;
1913
import com.fasterxml.jackson.databind.ObjectMapper;
2014
import com.fasterxml.jackson.databind.SerializationFeature;
@@ -76,12 +70,6 @@ public class ApiClient {
7670
{{#jackson}}
7771
objectMapper = createObjectMapper();
7872
feignBuilder = Feign.builder()
79-
{{#feign-okhttp}}
80-
.client(new OkHttpClient())
81-
{{/feign-okhttp}}
82-
{{#feign-hc5}}
83-
.client(new ApacheHttp5Client())
84-
{{/feign-hc5}}
8573
.encoder(new FormEncoder(new JacksonEncoder(objectMapper)))
8674
.decoder(new ApiResponseDecoder(objectMapper))
8775
{{#hasOAuthMethods}}

samples/client/petstore/java/feign-hc5/src/main/java/org/openapitools/client/ApiClient.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import java.util.logging.Level;
2020
import java.util.logging.Logger;
2121

22-
import feign.hc5.ApacheHttp5Client;
2322
import com.fasterxml.jackson.databind.DeserializationFeature;
2423
import com.fasterxml.jackson.databind.ObjectMapper;
2524
import com.fasterxml.jackson.databind.SerializationFeature;
@@ -60,7 +59,6 @@ public ApiClient() {
6059
apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>();
6160
objectMapper = createObjectMapper();
6261
feignBuilder = Feign.builder()
63-
.client(new ApacheHttp5Client())
6462
.encoder(new FormEncoder(new JacksonEncoder(objectMapper)))
6563
.decoder(new ApiResponseDecoder(objectMapper))
6664
.errorDecoder(new ApiErrorDecoder())

samples/client/petstore/java/feign-no-nullable/src/main/java/org/openapitools/client/ApiClient.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import java.util.logging.Level;
2020
import java.util.logging.Logger;
2121

22-
import feign.okhttp.OkHttpClient;
2322
import com.fasterxml.jackson.databind.DeserializationFeature;
2423
import com.fasterxml.jackson.databind.ObjectMapper;
2524
import com.fasterxml.jackson.databind.SerializationFeature;
@@ -59,7 +58,6 @@ public ApiClient() {
5958
apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>();
6059
objectMapper = createObjectMapper();
6160
feignBuilder = Feign.builder()
62-
.client(new OkHttpClient())
6361
.encoder(new FormEncoder(new JacksonEncoder(objectMapper)))
6462
.decoder(new ApiResponseDecoder(objectMapper))
6563
.errorDecoder(new ApiErrorDecoder())

samples/client/petstore/java/feign/src/main/java/org/openapitools/client/ApiClient.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import java.util.logging.Level;
2020
import java.util.logging.Logger;
2121

22-
import feign.okhttp.OkHttpClient;
2322
import com.fasterxml.jackson.databind.DeserializationFeature;
2423
import com.fasterxml.jackson.databind.ObjectMapper;
2524
import com.fasterxml.jackson.databind.SerializationFeature;
@@ -60,7 +59,6 @@ public ApiClient() {
6059
apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>();
6160
objectMapper = createObjectMapper();
6261
feignBuilder = Feign.builder()
63-
.client(new OkHttpClient())
6462
.encoder(new FormEncoder(new JacksonEncoder(objectMapper)))
6563
.decoder(new ApiResponseDecoder(objectMapper))
6664
.errorDecoder(new ApiErrorDecoder())

0 commit comments

Comments
 (0)