-
Notifications
You must be signed in to change notification settings - Fork 5
[tools] convert project metadata to PEP 621 pyproject.toml (#112) #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this improveent that modernizes the package.
It looks good to me.
I’ve suggested a non blocking small change to help make future updates a bit easier.
pyproject.toml
Outdated
| [tool.setuptools] | ||
| packages = [ | ||
| "pyobas", | ||
| "pyobas.apis", | ||
| "pyobas.apis.inject_expectation", | ||
| "pyobas.apis.inject_expectation.model", | ||
| "pyobas.backends", | ||
| "pyobas.configuration", | ||
| "pyobas.contracts", | ||
| "pyobas.daemons", | ||
| "pyobas.signatures" | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIP :
Since the repo appears to be well structured, I believe you can use setuptools automatic package discovery instead of specifying an explicit list:
[tool.setuptools.packages.find]
https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#custom-discovery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers for this, good thinking.
Signed-off-by: Antoine MAZEAS <[email protected]>
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...