Skip to content

[tools] convert project metadata to PEP 621 pyproject.toml (#112) #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025

Conversation

antoinemzs
Copy link
Contributor

Proposed changes

  • Put all project's metadata into pyproject.toml
  • Abandon setup.cfg and requirements.txt

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@antoinemzs antoinemzs changed the base branch from main to release/current June 4, 2025 13:21
Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs antoinemzs requested a review from flavienSindou June 4, 2025 13:39
Copy link

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this improveent that modernizes the package.

It looks good to me.

I’ve suggested a non blocking small change to help make future updates a bit easier.

pyproject.toml Outdated
Comment on lines 67 to 78
[tool.setuptools]
packages = [
"pyobas",
"pyobas.apis",
"pyobas.apis.inject_expectation",
"pyobas.apis.inject_expectation.model",
"pyobas.backends",
"pyobas.configuration",
"pyobas.contracts",
"pyobas.daemons",
"pyobas.signatures"
]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIP :
Since the repo appears to be well structured, I believe you can use setuptools automatic package discovery instead of specifying an explicit list:
[tool.setuptools.packages.find]
https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#custom-discovery

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for this, good thinking.

Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs antoinemzs merged commit c60df86 into release/current Jun 10, 2025
4 checks passed
@antoinemzs antoinemzs deleted the pep621 branch June 10, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project should conform to PEP 621 pyproject.toml
2 participants