feat(hub): add configuration to disable connectivity email notifications

Author: jbanety

opencti-platform/opencti-graphql/config/default.json

@@ -233,7 +233,8 @@
     "opengrc_url": "",
     "opengrc_token": "",
     "xtmhub_url": "https://hub.filigran.io",
-    "xtmhub_to_email": "[email protected]"
+    "xtmhub_to_email": "[email protected]",
+    "xtmhub_connectivity_email_enabled": true
   },
   "data_sharing": {
     "max_csv_feed_result": 5000

opencti-platform/opencti-graphql/src/domain/xtm-hub.ts

@@ -5,7 +5,7 @@ import { ENTITY_TYPE_SETTINGS } from '../schema/internalObject';
 import { xtmHubClient } from '../modules/xtm/hub/xtm-hub-client';
 import { XtmHubRegistrationStatus } from '../generated/graphql';
 import { updateAttribute } from '../database/middleware';
-import { BUS_TOPICS, PLATFORM_VERSION } from '../config/conf';
+import { booleanConf, BUS_TOPICS, PLATFORM_VERSION } from '../config/conf';
 import { HUB_REGISTRATION_MANAGER_USER } from '../utils/access';
 import { getSettings } from './settings';
 import { notify } from '../database/redis';
@@ -32,9 +32,11 @@ export const checkXTMHubConnectivity = async (context: AuthContext, user: AuthUs
 
   const lastCheckDate = utcDate(settings.xtm_hub_last_connectivity_check);
   const are24HoursPassed = utcDate().diff(lastCheckDate, 'hours') >= 24;
+  const isEmailEnabled = booleanConf('xtm:xtmhub_connectivity_email_enabled', true);
   const shouldSendLostConnectivityEmail = !isConnectivityActive
     && are24HoursPassed
-    && settings.xtm_hub_should_send_connectivity_email;
+    && settings.xtm_hub_should_send_connectivity_email
+    && isEmailEnabled;
   if (shouldSendLostConnectivityEmail) {
     await sendAdministratorsLostConnectivityEmail(context, settings);
     attributeUpdates.push({ key: 'xtm_hub_should_send_connectivity_email', value: [false] });

opencti-platform/opencti-graphql/tests/01-unit/domain/xtm-hub-test.ts

@@ -11,6 +11,7 @@ import { ENTITY_TYPE_SETTINGS } from '../../../src/schema/internalObject';
 import * as settingsModule from '../../../src/domain/settings';
 import * as redisModule from '../../../src/database/redis';
 import * as xtmHubEmail from '../../../src/modules/xtm/hub/xtm-hub-email';
+import * as conf from '../../../src/config/conf';
 
 describe('XTM hub', () => {
   describe('checkXTMHubConnectivity', () => {
@@ -195,6 +196,24 @@ describe('XTM hub', () => {
 
         expect(sendAdministratorsLostConnectivityEmailSpy).not.toBeCalled();
       });
+
+      it('should not send connectivity email when email sending is disabled via configuration', async () => {
+        const settings: Partial<BasicStoreSettings> = {
+          id: 'id',
+          xtm_hub_token,
+          xtm_hub_registration_status: XtmHubRegistrationStatus.LostConnectivity,
+          xtm_hub_last_connectivity_check: new Date(new Date().getTime() - 1000 * 60 * 60 * 24),
+          xtm_hub_should_send_connectivity_email: true,
+        };
+        getEntityFromCacheSpy.mockResolvedValue(settings);
+        xtmHubClientSpy.mockResolvedValue('inactive');
+        vi.spyOn(conf, 'booleanConf').mockReturnValue(false);
+
+        await checkXTMHubConnectivity(testContext, HUB_REGISTRATION_MANAGER_USER);
+
+        expect(sendAdministratorsLostConnectivityEmailSpy).not.toBeCalled();
+        expect(updateAttributeSpy).not.toBeCalled();
+      });
     });
   });
 });