Skip to content

Improve NPC goodbye message handling #4174

@boscv

Description

@boscv

Describe the solution you'd like

Something that always bothered me is this:

Task::TalkNPC::conversation_end called at ai npc_talk 'select'. 
Conversa com NPC Funcionária Kafra (0) finalizada. 
NPC Funcionária Kafra (0): Task::TalkNPC::DESTROY was called 
An unexpected npc conversation has started, auto-creating a TalkNPC Task Task::TalkNPC::new has been called with sequence ''. 
[Funcionária Kafra] A Corporação Kafra tem o enorme prazer em servir você.
Agradecemos por usar nossos serviços. 
Npc which started autotalk has automatically sent a 'npc_talk_done'. 
Client network buffer flushed out
Talking was initiated by the other side and finished instantly
Talking with NPC Funcionária Kafra (0) at (175,226), ID 1F 00 00 00 
NPC Funcionária Kafra (0): Sending talk cancel [id '31'] after NPC has done talking 

The task is immediately destroyed after chosing to end conversation, and then opens a new task to handle the goodbye message.
Maybe we can improve the task by letting the task wait for a goodbye message, before destroying it?

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions