Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window scale factor of 2.0 makes the middle half of the game window blurry at odd resolutions #2739

Open
LeeSpork opened this issue Nov 15, 2024 · 10 comments · May be fixed by #2740
Open

Window scale factor of 2.0 makes the middle half of the game window blurry at odd resolutions #2739

LeeSpork opened this issue Nov 15, 2024 · 10 comments · May be fixed by #2740

Comments

@LeeSpork
Copy link
Contributor

Version information:

  • Platform: Windows 10
  • Version: 24.10

Describe the issue
When the horizontal or vertical resolution of the game window is odd, using a 'window scale factor' of '2.0' causes the middle of the game window to appear blurred. This can happen quite easily when playing the game in Windowed mode, either by resizing the window, or by maximising it if your (Microsoft Windows) taskbar and/or title bar is of odd thickness.

Expected behaviour
I would expect 2x scale to always allow me to appreciate every pixel of the game in crisp detail, without feeling like I need to see an optometrist.

Describe the solution you'd like

  • When using a sale factor of 2.0, only the last row and column should be allowed to be wrongly scaled.

Describe alternatives you've considered

  • Forcing the window to be an even size (might be annoying for the case where the window is maximised)
  • One pixel of pillar-boxing/letter-boxing

Cropped screenshot
I find this especially annoying when reading text (screenshot cropped and scaled 4x):
Image

Annotated screenshot
Numbers are pixels measured in Paint.NET.
Annotated image detailing exact behaviour
Same screenshot but with only the resolution added for reference:
Non-annotated screenshot
@LeeSpork
Copy link
Contributor Author

LeeSpork commented Nov 15, 2024 •
edited
Loading

Making this if statement always false appears to fix the issue.

OpenLoco/src/OpenLoco/src/Graphics/SoftwareDrawingEngine.cpp

Line 157 in e9ab45c

if (scaleFactor > 1.0f)

Removing this block of code makes other other scale factors be not blurry as well, which may not be desired. Maybe this should be changed to check if the scale factor is any whole number, instead of only checking for 1.0?

@LeftofZen
Copy link
Contributor

Nice find. Given this is a pixelart game, I'm in favour of never blurring anything

@LeeSpork
Copy link
Contributor Author

Nice find. Given this is a pixelart game, I'm in favour of never blurring anything

I'll make a pull

@LeftofZen
Copy link
Contributor

Nice find. Given this is a pixelart game, I'm in favour of never blurring anything

I'll make a pull

I guess we should check, how does your change look at the non-integer scales?

@LeeSpork
Copy link
Contributor Author

Oh, not great
Image

@LeeSpork
Copy link
Contributor Author

LeeSpork commented Nov 15, 2024 •
edited
Loading

Verses 24.10 release version
Image

Values over 2.0 already look pretty good already as well.

@LeftofZen
Copy link
Contributor

ah yeah ok. so sounds like the original idea of blurring at non-integer scales was a good one 😅

except why is the options window behind the 4 globe buttons in the release...

@LeeSpork
Copy link
Contributor Author

except why is the options window behind the 4 globe buttons in the release...

It only sometimes is 🤷

@LeeSpork
Copy link
Contributor Author

LeeSpork commented Nov 15, 2024 •
edited
Loading

OpenLoco/src/OpenLoco/src/Graphics/SoftwareDrawingEngine.cpp

Line 160 in e9ab45c

// We only need this texture when we have a scale above 1x, this texture uses the actual canvas size.

This comment is incorrect after commit 3f97f50, in a way that appears to only be relevant when the scale is between 1 and 2 (by my limited testing)

@LeeSpork LeeSpork linked a pull request Nov 15, 2024 that will close this issue
Open
@LeeSpork
Copy link
Contributor Author

LeeSpork commented Nov 15, 2024 •
edited
Loading

BTW I believe the issue was that the size of _scaledScreenTexture was being set to the size of the actual window (widthxheight), multiplied by ceil(scaleFactor). In the case of odd window resolutions and a scaleFactor of 2, this was not dividable into the game resolution (scaledWidthxscaledHeight, which are the actual window size divided by scaleFactor) due to the latter being affected by integer division rounding.

@LeeSpork LeeSpork changed the title Windows scale factor of 2 makes the middle half of the game window blurry at odd resolutions Window scale factor of 2.0 makes the middle half of the game window blurry at odd resolutions Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@LeftofZen @LeeSpork