[BUG] Array to string conversion on saving category in store view

[Caprico85]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

When I try to save a category with an image in a specifc store view, I get an Array to string conversion

Expected Behavior

Saving a category works.

Steps To Reproduce

1. Run a OpenMage demo store using
   SAMPLE_DATA=1 HOST_PORT=94 HOST_NAME=172.17.2.20 ADMIN_HOST_NAME=172.17.2.20 dev/openmage/install.sh
   (can reproduce this on all our existing stores, so it probably doesn't matter how you run your store)
2. Go to Catalog -> Manage categories
3. Choose a specific store view. Doesn't matter which one (except "All Store Views")
   
4. Choose a category. Doesn't matter which one.
   
5. Assign an image to the category if there is not already one
   
6. Save the category
7. See the "Array to string conversion"

Environment

- OpenMage: Tested on 20.17.0 and 20.18.0
- php: Tested on 8.4 and 8.5

Anything else?

If there is no image assigned, saving the category works.

If an image is assigned, the value of the image element is loaded as an array.

[Caprico85]

The attached PR does NOT fix the problem. But making the change described in my first comment in #5626 does. I think fixing #5626 will probably also fix this issue.

[B3Hana]

The only way for me to reproduce the problem is by creating an error. If the category can be saved everything works fine, but if the validations fails, then the Array to string conversion is triggered.

(so fixing issue #5626 doesn't actually fix this issue)

A reliable way to generate a validation error is by setting Default Product Listing Sort By to not use the default value, while the Available Product Listing Sort By does. (this feels like yet another bug?)

[B3Hana]

Alright, the problem is the data it uses in the editAction.

If an error occurs while saving the category, it catches the error and saved the current category data into the session.
$this->_getSession()->addError($e->getMessage())->setCategoryData($data);

This will later be used in the editAction to override the data loaded by the model.

$data = Mage::getSingleton('adminhtml/session')->getCategoryData(true);
if (isset($data['general'])) {
    $category->addData($data['general']);
}

The problem is, while saving the data is part of an array (['value' => 'image_name']), while the loaded data of the editAction is only a string(if set) or null.

I could reproduce the error in v20.2.0 (can't get older versions to run without having to change stuff) so this is a long standing issue.