Fix: save newsletter template

[sreichel]

Description (*)

Cant save existing newsletter template b/c "template_type" has to be an integer value, string given.

• added getter/setter
• added save success message
• added cypress test

Related Pull Requests

• see Replace Zend_Validate with symfony/validator #4612

Manual testing scenarios (*)

1. go to admnin - newsletter - template
2. save an existing template

[Copilot]

Pull request overview

Fixes saving existing newsletter templates by ensuring template_type is handled as an integer (matching validation expectations), and adds UI/test coverage for a successful save in the admin newsletter template editor.

Changes:

• Add explicit getTemplateType()/setTemplateType() implementations in Mage_Newsletter_Model_Template to coerce template_type to int.
• Add an admin session success message after saving a newsletter template.
• Update Cypress e2e to cover saving an existing newsletter template and assert the success message.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
cypress/e2e/openmage/backend/newsletter/template.cy.js	Updates edit-route test to save an existing template and check for a success message.
app/locale/en_US/Mage_Newsletter.csv	Adds a new translation string for the save success message.
app/code/core/Mage/Newsletter/Model/Template.php	Introduces typed getter/setter for template_type to satisfy int validation.
app/code/core/Mage/Core/Model/Email/Template/Abstract.php	Docblock updates for template text/type method annotations.
app/code/core/Mage/Adminhtml/controllers/Newsletter/TemplateController.php	Adds a save success message and returns immediately after redirect.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sreichel]

@all-contributors add @B3Hana code

[allcontributors]

@sreichel

I've put up a pull request to add @B3Hana! 🎉

[Hanmac]

validateType might not be needed, because validateChoice already restricts it to [1, 2]

But better safe than sorry?

[sreichel]

validateType might not be needed, because validateChoice already restricts it to [1, 2]

But better safe than sorry?

Good one ... not sure/untested if validateChoice is type-safe. (1 vs "1").

[sreichel]

Want to add a new test case?

[Hanmac]

validateType might not be needed, because validateChoice already restricts it to [1, 2]
But better safe than sorry?

Good one ... not sure/untested if validateChoice is type-safe. (1 vs "1").

https://github.com/symfony/symfony/blob/5bcd98749de899a7de2e0052e9234ca028cde867/src/Symfony/Component/Validator/Constraints/ChoiceValidator.php#L100
checks:

} elseif ($constraint->match xor \in_array($value, $choices, true)) {

this says that strict makes it type-safe:
https://www.php.net/manual/en/function.in-array.php

If the third parameter strict is set to true then the in_array() function will also check the types of the needle in the haystack.

so no extra test case needed

[sreichel]

PR to remove additional check?