Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IntroRemoteDS-pre] Execution Cell Count & Output not cleared in L3_DataPreparation #380

Open
leriomaggio opened this issue Nov 17, 2021 · 0 comments
Labels
Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor

Comments

@leriomaggio
Copy link

Description

Cell output (and corresponding cell execution count) have not been cleared in L3_DataPreparation.ipynb notebook.

Just noticed as I started working on Lesson 3 in the course Pre-release :)

Are you interested in working on this improvement yourself?

  • Yes, I am.

Additional Context

Also execution counts are not in consecutive order, so this might be even more confusing.

Happy to send a PR myself, but I think it would be quicker if you'd prefer doing it on your end.

HTH

@leriomaggio leriomaggio added the Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor label Nov 17, 2021
leriomaggio added a commit to leriomaggio/courses that referenced this issue Nov 17, 2021
This commit fixes a few minors in the L3_DataPreparation notebook
after coding through the first block of Lecture 3 in Introduction
to Remote Data Science pre-release.

This commit addresses Issue OpenMined#380 OpenMined#381 OpenMined#382
Moreover:
- duplicates in raw_data should be applied inplace
- plt.show() whenever a plot is generated to avoid
the repr of the Axis object
- the plot_extrapolated_country function had a missing import
of numpy as np
- x = list(range(53)) has been updated as per drop inplace
- iloc is used whenever accessing an entry in the DataFrame.
(Without iloc, the code doesn't work)
@leriomaggio leriomaggio changed the title Execution Cell Count & Output not cleared in L3_DataPreparation [IntroRemoteDS-pre] Execution Cell Count & Output not cleared in L3_DataPreparation Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor
Projects
None yet
Development

No branches or pull requests

1 participant