Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IntroRemoteDS-pre] L3_DataPreparation: Number of Cases reported for Country zero is wrong #382

Open
leriomaggio opened this issue Nov 17, 2021 · 0 comments
Open

[IntroRemoteDS-pre] L3_DataPreparation: Number of Cases reported for Country zero is wrong #382

leriomaggio opened this issue Nov 17, 2021 · 0 comments
Labels
Type: Documentation 📚 Improvements or additions in documentation for some file, feature, or codebase

Comments

@leriomaggio
Copy link

Where?

L3_DataPreparation.ipynb in introduction-to-remote-data-science branch.

What?

The following sentence is not aligned with actual data:

So for instance, Country 0 had 1140 COVID cases at the start of when this data was collected (row 0), and only 451 when the data was last collected (row 53).

Initial COVID cases for Country 0 is 2280 and not 1140 :)

HTH
@leriomaggio leriomaggio added the Type: Documentation 📚 Improvements or additions in documentation for some file, feature, or codebase label Nov 17, 2021
leriomaggio added a commit to leriomaggio/courses that referenced this issue Nov 17, 2021
@leriomaggio
Cleared Output, missing import, drop inplace, iloc
ac8b077 
This commit fixes a few minors in the L3_DataPreparation notebook
after coding through the first block of Lecture 3 in Introduction
to Remote Data Science pre-release.

This commit addresses Issue OpenMined#380 OpenMined#381 OpenMined#382
Moreover:
- duplicates in raw_data should be applied inplace
- plt.show() whenever a plot is generated to avoid
the repr of the Axis object
- the plot_extrapolated_country function had a missing import
of numpy as np
- x = list(range(53)) has been updated as per drop inplace
- iloc is used whenever accessing an entry in the DataFrame.
(Without iloc, the code doesn't work)
@leriomaggio leriomaggio mentioned this issue Nov 17, 2021
Open
4 tasks
@leriomaggio leriomaggio changed the title L3_DataPreparation: Number of Cases reported for Country zero is wrong [Intro to Remote Data Science Pre-Release] L3_DataPreparation: Number of Cases reported for Country zero is wrong Nov 17, 2021
@leriomaggio leriomaggio changed the title [Intro to Remote Data Science Pre-Release] L3_DataPreparation: Number of Cases reported for Country zero is wrong [IntroRemoteDS-pre] L3_DataPreparation: Number of Cases reported for Country zero is wrong Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Documentation 📚 Improvements or additions in documentation for some file, feature, or codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leriomaggio