Skip to content

Commit aad6079

Browse files
committed
Fixed issue with tests and also allowed procstats to exit gracefully
1 parent f4b3b29 commit aad6079

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

collectors/0/procstats.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -142,14 +142,17 @@ def cpus_csets(cpuset_path):
142142

143143
def main():
144144
"""procstats main loop"""
145-
146-
f_uptime = open("/proc/uptime", "r")
147-
f_meminfo = open("/proc/meminfo", "r")
148-
f_vmstat = open("/proc/vmstat", "r")
149-
f_stat = open("/proc/stat", "r")
150-
f_loadavg = open("/proc/loadavg", "r")
151-
f_entropy_avail = open("/proc/sys/kernel/random/entropy_avail", "r")
152-
f_interrupts = open("/proc/interrupts", "r")
145+
try:
146+
f_uptime = open("/proc/uptime", "r")
147+
f_meminfo = open("/proc/meminfo", "r")
148+
f_vmstat = open("/proc/vmstat", "r")
149+
f_stat = open("/proc/stat", "r")
150+
f_loadavg = open("/proc/loadavg", "r")
151+
f_entropy_avail = open("/proc/sys/kernel/random/entropy_avail", "r")
152+
f_interrupts = open("/proc/interrupts", "r")
153+
except FileNotFoundError as exc:
154+
utils.err('FileNotFoundError: %s' % (sys.exc_info()[1]))
155+
sys.exit(1)
153156

154157
f_scaling = "/sys/devices/system/cpu/cpu%s/cpufreq/%s_freq"
155158
f_scaling_min = dict([])

tests.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,8 @@ def test_endtoend(self):
158158
"a": tcollector.Collector("mycollector", 5, "a.py"), # pylint:disable=no-member
159159
"b": tcollector.Collector("second", 3, "b.py"), # pylint:disable=no-member
160160
}
161-
server = tcollector.StatusServer("127.0.0.1", 32025, collectors) # pylint:disable=no-member
161+
reader = {}
162+
server = tcollector.StatusServer("127.0.0.1", 32025, collectors, reader) # pylint:disable=no-member
162163
# runs in background until test suite exits :( but it works.
163164
thread = threading.Thread(target=server.serve_forever)
164165
thread.setDaemon(True)

0 commit comments

Comments
 (0)