Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making BlobRefRegistry a library #86

Open
ggonzalez94 opened this issue Mar 25, 2025 · 1 comment
Open

Consider making BlobRefRegistry a library #86

ggonzalez94 opened this issue Mar 25, 2025 · 1 comment
Labels
needs discussion This issue still needs discussion before implementing

Comments

@ggonzalez94
Copy link
Collaborator

One of the ideas of the BlobRefRegistry contract was to serve as a common piece of infrastructure where blob hashes are validated and registered. If used by multiple rollups, this can save some gas and simplify their code. But whoever calls registerRef has to pay the SSTORE cost. Because of that, in our current version of the rollup we are not using this functionality, we are directly calling getRef to validate the blobs and return a reference.
If this continues to be the case, then it maybe makes more sense to simplify the implementation and convert the functionalities we are using into a library or just embed the logic into the contracts

@ggonzalez94 ggonzalez94 added the needs discussion This issue still needs discussion before implementing label Mar 25, 2025
@ggonzalez94
Copy link
Collaborator Author

We are now actually using the register function in the DelayedInclusionStore, but what we actually need is only the event to get emitted, so we might still want to simplify this(the cost for paying for storage is not necessary unless multiple rollups actually leverage that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion This issue still needs discussion before implementing
Projects
None yet
Development

No branches or pull requests

1 participant