Merge pull request #454 from OperationCode/fix_zip_validation

Only validate zip on create

Author: apex-omontgomery

app/models/user.rb

@@ -41,7 +41,7 @@ class User < ApplicationRecord
 
   validates_format_of :email, :with => VALID_EMAIL
   validates :email, uniqueness: true
-  validates :zip, presence: true
+  validates :zip, presence: true, :on => :create
 
   has_many :requests
   has_many :votes

test/models/user_test.rb

@@ -82,6 +82,22 @@ def teardown
     assert ["Zip can't be blank"], user.errors.full_messages
   end
 
+  test 'longitude and longitude are nil for nil zipcodes' do
+    Geocoder::Lookup::Test.add_stub('bad zip code', [{}])
+    u = build(:user, latitude: nil, longitude: nil, zip: nil)
+    u.update_attributes(zip: nil)
+    assert_nil u.latitude
+    assert_nil u.longitude
+  end
+
+  test 'longitude and longitude are nil for empty zipcodes' do
+    Geocoder::Lookup::Test.add_stub('bad zip code', [{}])
+    u = build(:user, latitude: nil, longitude: nil, zip: '')
+    u.update_attributes(zip: '')
+    assert_nil u.latitude
+    assert_nil u.longitude
+  end
+
   test 'longitude and longitude are nil for unknown zipcodes' do
     Geocoder::Lookup::Test.add_stub('bad zip code', [{}])