Skip to content

[#1439] Update badge icon to v1.3#1525

Draft
pylapp wants to merge 7 commits into
developfrom
1439-for-component-badge-icon-update-to-v13
Draft

[#1439] Update badge icon to v1.3#1525
pylapp wants to merge 7 commits into
developfrom
1439-for-component-badge-icon-update-to-v13

Conversation

@pylapp

@pylapp pylapp commented May 22, 2026

Copy link
Copy Markdown
Member

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#1439

Description

Use new icons and sizes

Motivation & Context

Apply new Figma specifications

Types of change

  • Refactoring (non-breaking change)

Previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibility review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

pylapp added 2 commits May 22, 2026 14:22
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp requested a review from ludovic35 as a code owner May 22, 2026 14:16
@pylapp pylapp linked an issue May 22, 2026 that may be closed by this pull request
8 tasks
@pylapp pylapp marked this pull request as draft May 22, 2026 14:17
@pylapp

pylapp commented May 22, 2026

Copy link
Copy Markdown
Member Author

Note

Still in draft because answers are needed about space inset token

@pylapp

pylapp commented May 22, 2026

Copy link
Copy Markdown
Member Author

Verbatims of @MaximeTonnerre :

Oui c'est à retirer uniquement sur les 4 variants : Negative, Positive, Info et Warning.
Car les 4 icônes prennent toute la place disponible dans la frame parente contrairement au Neutral et Accent.
 
comme il y a 2 nouvelles sizes, il y a 2 nouveaux tokens inset pour le Neutral et le Accent

Tip

When implemented and reviewed, an alpha build should be done

pylapp added 5 commits May 26, 2026 15:51
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

For component badge icon, update to v1.3

2 participants