Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrchardCore.Benchmarks uses a default namespace different of the project name. #17588

Closed
Piedone opened this issue Mar 9, 2025 · 4 comments · Fixed by #17589
Closed

OrchardCore.Benchmarks uses a default namespace different of the project name. #17588

Piedone opened this issue Mar 9, 2025 · 4 comments · Fixed by #17589

Comments

@Piedone
Copy link
Member

Piedone commented Mar 9, 2025

Describe the bug

The OrchardCore.Benchmarks project uses the OrchardCore.Benchmark (note that it's singular) default namespace. This is confusing and unnecessary.

Orchard Core version

Latest main: db618bc

To Reproduce

See

<RootNamespace>OrchardCore.Benchmark</RootNamespace>

Expected behavior

The default namespace, and the namespace of the already existing types in the project, are the same, OrchardCore.Benchmarks.

Logs and screenshots

@Piedone
Copy link
Member Author

Piedone commented Mar 9, 2025

Looks like a small oversight and easy fix, right, @MikeAlhayek?

@hishamco
Copy link
Member

hishamco commented Mar 9, 2025

There is no need for the root namespace attribute here as you mentioned

@MikeAlhayek
Copy link
Member

We may be able to just remove the namespace since it's the same as the project name.

@hishamco
Copy link
Member

hishamco commented Mar 9, 2025

I don't think so, Also we will get an unnecessary warning CA1050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants