Allow old Compounding Staking Strategy SSV validators to be removed#2914
Merged
naddison36 merged 3 commits intoJun 9, 2026
Merged
Conversation
…trategy on the ConsolidationController
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nicka/vanilla-staking #2914 +/- ##
=========================================================
+ Coverage 50.95% 51.25% +0.29%
=========================================================
Files 110 110
Lines 4914 4917 +3
Branches 1358 1361 +3
=========================================================
+ Hits 2504 2520 +16
+ Misses 2406 2392 -14
- Partials 4 5 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… so the 10 validators can be removed post upgrade
…a/remove-compounding-ssv-validators
sparrowDom
reviewed
Jun 9, 2026
sparrowDom
reviewed
Jun 9, 2026
| ownerAddress: cCompoundingStakingSSVStrategyProxy.address, | ||
| }); | ||
|
|
||
| if (isFork && Number(compoundingSsvCluster.validatorCount) !== 0) { |
Member
There was a problem hiding this comment.
nit: we would normally do any fork specific setup in the fixtures with the purpose of keeping the deploy files as clean as possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows the 10 exited validators in the old
CompoundingStakingSSVStrategySSV cluster to be removed via the newConsolidationController, then splits the old strategy cleanup into a follow-up governance proposal.This avoids requiring the old SSV cluster to be empty before deploy script 196 executes.
Changes
ConsolidationControllersoremoveSsvValidator(...)can forward removals for:CompoundingStakingSSVStrategyCompoundingStakingSSVStrategyinto theConsolidationControllerconstructor.--consolsupport so removals can go throughConsolidationController.ethBalanceas the clusterbalance.Operational Flow