Skip to content

Updated ValidatorState.NON_REGISTERED comment#2916

Merged
naddison36 merged 1 commit into
nicka/vanilla-stakingfrom
nicka/sp-ORGN4-02
Jun 9, 2026
Merged

Updated ValidatorState.NON_REGISTERED comment#2916
naddison36 merged 1 commit into
nicka/vanilla-stakingfrom
nicka/sp-ORGN4-02

Conversation

@naddison36

Copy link
Copy Markdown
Collaborator

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@naddison36 naddison36 merged commit c523ee2 into nicka/vanilla-staking Jun 9, 2026
14 of 15 checks passed
@naddison36 naddison36 deleted the nicka/sp-ORGN4-02 branch June 9, 2026 09:31
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.25%. Comparing base (94a41fb) to head (2fdd937).
⚠️ Report is 2 commits behind head on nicka/vanilla-staking.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           nicka/vanilla-staking    #2916      +/-   ##
=========================================================
+ Coverage                  50.95%   51.25%   +0.29%     
=========================================================
  Files                        110      110              
  Lines                       4914     4917       +3     
  Branches                    1358     1361       +3     
=========================================================
+ Hits                        2504     2520      +16     
+ Misses                      2406     2392      -14     
- Partials                       4        5       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sparrowDom

Copy link
Copy Markdown
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants