DO NOT PULL - see #149 | Squiz/NonExecutableCode: add extra defensive coding

THIS SHOULD BE FIXED IN THE TOKENIZER INSTEAD.

Includes unit test.

Author: jrfnl

src/Standards/Squiz/Sniffs/PHP/NonExecutableCodeSniff.php

@@ -109,7 +109,9 @@ public function process(File $phpcsFile, $stackPtr)
             $next = $phpcsFile->findNext(Tokens::$emptyTokens, ($stackPtr + 1), null, true);
             if ($tokens[$next]['code'] === T_SEMICOLON) {
                 $next = $phpcsFile->findNext(Tokens::$emptyTokens, ($next + 1), null, true);
-                if ($tokens[$next]['code'] === T_CLOSE_CURLY_BRACKET) {
+                if ($tokens[$next]['code'] === T_CLOSE_CURLY_BRACKET
+                    && isset($tokens[$next]['scope_condition']) === true
+                ) {
                     // If this is the closing brace of a function
                     // then this return statement doesn't return anything
                     // and is not required anyway.
@@ -123,7 +125,7 @@ public function process(File $phpcsFile, $stackPtr)
                     }
                 }
             }
-        }
+        }//end if
 
         if (isset($tokens[$stackPtr]['scope_opener']) === true) {
             $owner = $tokens[$stackPtr]['scope_condition'];

src/Standards/Squiz/Tests/PHP/NonExecutableCodeUnitTest.1.inc

@@ -418,3 +418,11 @@ $closure = function ()
     echo 'foo';
     return; // This return should be flagged as not required.
 };
+
+// Safeguard against an "Undefined array key "scope_condition"" notice.
+if (foo(<<<EOD
+foobar!
+EOD
+)) {
+    return;
+}