Skip to content

Commit 3715378

Browse files
committed
Fix: update assertions for image target format in MediaTest
1 parent a9df2d7 commit 3715378

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

tests/PhpWordTests/Writer/WPS/MediaTest.php

+9-5
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public function testAddElement(): void
3838
Media::addElement('section', $imageElement);
3939
$elements = Media::getElements('section');
4040
self::assertCount(1, $elements);
41-
self::assertEquals('section', $elements[0]['target']);
41+
self::assertMatchesRegularExpression('/^image\d+\.jpg$/', $elements[0]['target']);
4242
self::assertEquals($imagePath, $elements[0]['source']);
4343
self::assertStringStartsWith('image1.', $elements[0]['target']);
4444

@@ -47,18 +47,19 @@ public function testAddElement(): void
4747
Media::addElement('header', $headerImageElement);
4848
$headerElements = Media::getElements('header');
4949
self::assertCount(1, $headerElements);
50-
self::assertEquals('header', $headerElements[0]['target']);
50+
self::assertMatchesRegularExpression('/^image\d+\.jpg$/', $headerElements[0]['target']);
5151
self::assertEquals($imagePath, $headerElements[0]['source']);
52-
self::assertStringStartsWith('image1.', $headerElements[0]['target']);
52+
// The counter may increment, so check for image2.
53+
self::assertStringStartsWith('image2.', $headerElements[0]['target']);
5354

5455
// Add footer media
5556
$footerImageElement = new Image($imagePath);
5657
Media::addElement('footer', $footerImageElement);
5758
$footerElements = Media::getElements('footer');
5859
self::assertCount(1, $footerElements);
59-
self::assertEquals('footer', $footerElements[0]['target']);
60+
self::assertMatchesRegularExpression('/^image\d+\.jpg$/', $footerElements[0]['target']);
6061
self::assertEquals($imagePath, $footerElements[0]['source']);
61-
self::assertStringStartsWith('image1.', $footerElements[0]['target']);
62+
self::assertStringStartsWith('image3.', $footerElements[0]['target']);
6263

6364
// Test invalid container type - Note: addElement doesn't validate docPart string anymore,
6465
// it just creates a new key in the $elements array.
@@ -67,6 +68,9 @@ public function testAddElement(): void
6768
Media::addElement('invalid', $invalidImageElement);
6869
$invalidElements = Media::getElements('invalid');
6970
self::assertCount(1, $invalidElements); // Element is added under 'invalid' key
71+
self::assertMatchesRegularExpression('/^image\d+\.jpg$/', $invalidElements[0]['target']);
72+
self::assertEquals($imagePath, $invalidElements[0]['source']);
73+
self::assertStringStartsWith('image4.', $invalidElements[0]['target']);
7074

7175
// Check counts for valid types remain unchanged by the 'invalid' add
7276
$allValidElements = ['section', 'header', 'footer'];

0 commit comments

Comments
 (0)