Skip to content

Commit a9da4f2

Browse files
committed
pyDKB/common: add default prefix to log function (caller module name).
If used from `LoggableObject`, prefix is the caller class name (passed via `LoggableObject.log` method). If no prefix passed, caller module name is used instead. `LoggableObject` method does not support additional prefixes, yet if `log` function is called directly, prefixes can be passed and in this case caller `__name__` should be passed explicitly.
1 parent a9b2ba5 commit a9da4f2

4 files changed

Lines changed: 7 additions & 4 deletions

File tree

Utils/Dataflow/pyDKB/common/hdfs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def check_stderr(proc, timeout=None, max_lines=1):
3434
if err:
3535
n_lines += 1
3636
if max_lines is None or n_lines <= max_lines:
37-
log("%s" % err, logLevel.INFO, 'proc')
37+
log("%s" % err, logLevel.INFO, __name__, 'proc')
3838
if proc.poll():
3939
raise subprocess.CalledProcessError(proc.returncode, None)
4040
return proc.poll()

Utils/Dataflow/pyDKB/common/misc.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"""
66

77
import sys
8+
import inspect
89

910
from types import logLevel
1011

@@ -26,7 +27,9 @@ def log(message, level=logLevel.INFO, *args):
2627
if args:
2728
prefix = ' ' + ' '.join(['(%s)' % p for p in args])
2829
else:
29-
prefix = ''
30+
frm = inspect.stack()[1]
31+
mod = inspect.getmodule(frm[0])
32+
prefix = ' (%s)' % mod.__name__
3033
if lines:
3134
out_message = "(%s)%s %s" % (logLevel.memberName(level),
3235
prefix, lines[0])

Utils/Dataflow/pyDKB/dataflow/cds.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from invenio_client.contrib import cds
2121
import splinter
2222
except ImportError, e:
23-
log("%s failed (%s)\n" % (__name__, e), logLevel.WARN)
23+
log("Submodule failed (%s)" % e, logLevel.WARN)
2424
__all__ = []
2525
else:
2626

Utils/Dataflow/test/pyDKB/test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ test_case() {
5252
after=`cat $case/after 2>/dev/null`
5353

5454
eval "$before $cmd; $after" 2>&1 1> out.tmp | \
55-
grep -a -v '(WARN) pyDKB.dataflow.cds failed (No module named invenio_client.contrib)' | \
55+
grep -a -v '(WARN) (pyDKB.dataflow.cds) Submodule failed (No module named invenio_client.contrib)' | \
5656
sed -e"s#$base_dir#\$base_dir#" > err.tmp
5757

5858
err_correct=0

0 commit comments

Comments
 (0)