Skip to content

Restore ArmorStand items if EntityDeathEvent is cancelled #12288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Doc94
Copy link
Contributor

@Doc94 Doc94 commented Mar 14, 2025

Closes #12286
This PR make a copy of the items removed and added to drop (hand/armor) and check if the event was cancelled for restore, also double method called maybe for the hardfork thing.

@Doc94 Doc94 requested a review from a team as a code owner March 14, 2025 01:50
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Mar 14, 2025
@Warriorrrr Warriorrrr added the type: bug Something doesn't work as it was intended to. label Mar 17, 2025
@notTamion
Copy link
Member

I think it would be better if we moved the removal of the items past the dropAllDeathLoot call so we don't remove those items at all before we know the event was cancelled. this way. this would also restore parity with other entities which also have the event called with their equipment/items still on

@Doc94
Copy link
Contributor Author

Doc94 commented Apr 12, 2025

I think it would be better if we moved the removal of the items past the dropAllDeathLoot call so we don't remove those items at all before we know the event was cancelled. this way. this would also restore parity with other entities which also have the event called with their equipment/items still on

that not require a littlle more refactor for another behaviours rather than just the armorstand?

@notTamion
Copy link
Member

I was thinking about something like this: https://pastes.dev/3ZkbtqLipa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something doesn't work as it was intended to.
Projects
Status: Awaiting review
Development

Successfully merging this pull request may close these issues.

Cancelling EntityDeathEvent for an Armorstand Loses Items
3 participants