Skip to content

EntityShootBowEvent doesn't work correctly #10640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Ender-Fake opened this issue May 1, 2024 · 6 comments · May be fixed by #12308
Open

EntityShootBowEvent doesn't work correctly #10640

Ender-Fake opened this issue May 1, 2024 · 6 comments · May be fixed by #12308
Labels
status: needs triage type: bug Something doesn't work as it was intended to. version: 1.20.5 Game version 1.20.5

Comments

@Ender-Fake
Copy link

Ender-Fake commented May 1, 2024 •
edited
Loading

Expected behavior

getForce() should return 1.0 at maximum bow tension

Observed/Actual behavior

getForce() at maximum bow tension returns the value 3

Steps/models to reproduce

run method getForce() in EntityShootBowEvent

Plugin and Datapack List

example plugin for send getForce() to chat

Paper version

This server is running Paper version git-Paper-22 (MC: 1.20.5) (Implementing API version 1.20.5-R0.1-SNAPSHOT) (Git: 8f7ac62)

Other

power is limited to 3.0 and not 1.0
@Ender-Fake Ender-Fake added status: needs triage type: bug Something doesn't work as it was intended to. labels May 1, 2024
@papermc-sniffer papermc-sniffer bot added the version: 1.20.5 Game version 1.20.5 label May 1, 2024
@papermc-projects papermc-projects bot moved this to 🕑 Needs Triage in Issues: Bugs May 1, 2024
@electronicboy
Copy link
Member

power? you mean force?

@Ender-Fake
Copy link
Author

yes, I was a little mistaken

@Ender-Fake Ender-Fake closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2024
@github-project-automation github-project-automation bot moved this from 🕑 Needs Triage to Done in Issues: Bugs May 1, 2024
@papermc-projects papermc-projects bot moved this from Done to Invalid in Issues: Bugs May 1, 2024
@Ender-Fake Ender-Fake reopened this May 1, 2024
@papermc-projects papermc-projects bot moved this from Invalid to 🕑 Needs Triage in Issues: Bugs May 1, 2024
@electronicboy
Copy link
Member

So, this behavior looks like it WAI and that JDs are outdated, the server has an explicit * 3 to the "speed" (what gets referred to as force) in the path from some value which is capped to 1 based upon the use time

@Ender-Fake
Copy link
Author

Previously, the "Force" parameter was responsible for how much the bow was stretched, and now
it is not responsible for this, but the documentation says that it is limited to 1. so, either you need to fix the "Force" so that it would be as before, or there should be a separate variable to get the tension force, and in the documentation fix the restriction in the form of 1

@TothAdam0012
Copy link

Is this intended then? Because the javadocs still says 1.0 but it actually return 3 for a full charge.

@electronicboy
Copy link
Member

The thing has been returning the speed for years, not the force. It's not exactly intended, but "that's been the implementation for so long now" unless upstream removed a division at some point.

@JasperLorelai JasperLorelai mentioned this issue Mar 16, 2025
Open
2 tasks
@TonytheMacaroni TonytheMacaroni linked a pull request Mar 16, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs triage type: bug Something doesn't work as it was intended to. version: 1.20.5 Game version 1.20.5
Projects
Issues: Bugs
Status: 🕑 Needs Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass correct draw strength for EntityShootBowEvent TonytheMacaroni/Paper
3 participants
@electronicboy @Ender-Fake @TothAdam0012