Replace Yield with Delay to not hammer the CPU (#6831) (#6833)

Daniel Marbach · ramonsmits · web-flow · commit 1ef06e3810ba · 2023-09-01T10:35:50.000Z
Co-authored-by: Ramon Smits &lt;ramon.smits@gmail.com&gt;
diff --git a/src/NServiceBus.AcceptanceTesting/Support/ScenarioRunner.cs b/src/NServiceBus.AcceptanceTesting/Support/ScenarioRunner.cs
@@ -91,7 +91,7 @@ static async Task PerformScenarios(RunDescriptor runDescriptor, ComponentRunner[
                             }
                         }
 
-                        await Task.Yield();
+                        await Task.Delay(100).ConfigureAwait(false);
                     }
 
                     startTime = DateTime.UtcNow;
@@ -103,7 +103,7 @@ static async Task PerformScenarios(RunDescriptor runDescriptor, ComponentRunner[
                             throw new Exception("Some failed messages were not handled by the recoverability feature.");
                         }
 
-                        await Task.Yield();
+                        await Task.Delay(100).ConfigureAwait(false);
                     }
                 }
                 finally

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ static async Task PerformScenarios(RunDescriptor runDescriptor, ComponentRunner[`
`91`	`91`	`}`
`92`	`92`	`}`
`93`	`93`
`94`		`- await Task.Yield();`
	`94`	`+ await Task.Delay(100).ConfigureAwait(false);`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`startTime = DateTime.UtcNow;`
`@@ -103,7 +103,7 @@ static async Task PerformScenarios(RunDescriptor runDescriptor, ComponentRunner[`
`103`	`103`	`throw new Exception("Some failed messages were not handled by the recoverability feature.");`
`104`	`104`	`}`
`105`	`105`
`106`		`- await Task.Yield();`
	`106`	`+ await Task.Delay(100).ConfigureAwait(false);`
`107`	`107`	`}`
`108`	`108`	`}`
`109`	`109`	`finally`