Revert "Remove mathoms stub Perl_save_freepv()"

khwilliamson · khwilliamson · commit 03ff823369b4 · 2025-04-20T12:13:58.000-06:00
This reverts commit 9d5c1af.
diff --git a/embed.fnc b/embed.fnc
@@ -2935,7 +2935,7 @@ Cp	|void	|save_destructor_x					\
 				|NULLOK void *p
 : Used in SAVEFREOP(), used in op.c, pp_ctl.c
 CMbp	|void	|save_freeop	|NULLOK OP *o
-Cmp	|void	|save_freepv	|NULLOK char *pv
+CMbp	|void	|save_freepv	|NULLOK char *pv
 Cdp	|void	|save_freercpv	|NN char *rcpv
 CMbp	|void	|save_freesv	|NULLOK SV *sv
 Cdp	|void	|save_generic_pvref					\
diff --git a/embed.h b/embed.h
@@ -602,7 +602,6 @@
 # define save_delete(a,b,c)                     Perl_save_delete(aTHX_ a,b,c)
 # define save_destructor(a,b)                   Perl_save_destructor(aTHX_ a,b)
 # define save_destructor_x(a,b)                 Perl_save_destructor_x(aTHX_ a,b)
-# define save_freepv(a)                         Perl_save_freepv(aTHX,a)
 # define save_freercpv(a)                       Perl_save_freercpv(aTHX_ a)
 # define save_generic_pvref(a)                  Perl_save_generic_pvref(aTHX_ a)
 # define save_generic_svref(a)                  Perl_save_generic_svref(aTHX_ a)
diff --git a/mathoms.c b/mathoms.c
@@ -660,6 +660,12 @@ Perl_save_freeop(pTHX_ OP *o)
     save_freeop(o);
 }
 
+void
+Perl_save_freepv(pTHX_ char *pv)
+{
+    save_freepv(pv);
+}
+
 void
 Perl_save_op(pTHX)
 {
diff --git a/proto.h b/proto.h
diff --git a/scope.h b/scope.h
@@ -309,8 +309,7 @@ STMT_START {                                 \
       _o->op_savefree = 1;                     \
       save_pushptr((void *)(_o), SAVEt_FREEOP); \
     } STMT_END
-#define Perl_save_freepv(mTHX, pv)                          \
-        Perl_save_pushptr(aTHX_ (void *)(pv), SAVEt_FREEPV)
+#define save_freepv(pv)		save_pushptr((void *)(pv), SAVEt_FREEPV)
 
 /*
 =for apidoc_section $callback

Original file line number	Diff line number	Diff line change
`@@ -660,6 +660,12 @@ Perl_save_freeop(pTHX_ OP *o)`
`660`	`660`	`save_freeop(o);`
`661`	`661`	`}`
`662`	`662`
	`663`	`+void`
	`664`	`+Perl_save_freepv(pTHX_ char *pv)`
	`665`	`+{`
	`666`	`+ save_freepv(pv);`
	`667`	`+}`
	`668`	`+`
`663`	`669`	`void`
`664`	`670`	`Perl_save_op(pTHX)`
`665`	`671`	`{`