Switch most open() calls to three-argument form.

Switch from two-argument form.  Filehandle cloning is still done with the two
argument form for backward compatibility.

Committer:  Get all porting tests to pass.  Increment some $VERSIONs.
Run: ./perl -Ilib regen/mk_invlists.pl; ./perl -Ilib regen/regcharclass.pl

For: RT #130122

Author: John Lightsey

Cross/generate_config_sh

@@ -44,7 +44,7 @@ if ($config eq "") {
 	die("Please run me as generate_config_sh path/to/original/config.sh");
 }
 
-open(FILE, "$config") || die("Unable to open $config");
+open(FILE, '<', $config) || die("Unable to open $config");
 
 my $line_in;
 while ($line_in = <FILE>) {

NetWare/config_h.PL

@@ -19,7 +19,7 @@ $patchlevel =~ s|~VERSION~|$Config{version}|g;
 $patchlevel ||= $Config{version};
 $patchlevel = qq["$patchlevel"];
 
-open(SH,"<$name") || die "Cannot open $name:$!";
+open(SH,'<',$name) || die "Cannot open $name:$!";
 while (<SH>)
  {
   last if /^sed/;
@@ -42,7 +42,7 @@ eval $str;
 
 die "$str:$@" if $@;
 
-open(H,">$file.new") || die "Cannot open $file.new:$!";
+open(H,'>',"$file.new") || die "Cannot open $file.new:$!";
 binmode H;		# no CRs (which cause a spurious rebuild)
 while (<SH>)
  {

NetWare/config_sh.PL

@@ -18,7 +18,7 @@ sub loadopts {
 	shift @ARGV;
 	my $optfile = shift @ARGV;
 	local (*F);
-	open OPTF, $optfile or die "Can't open $optfile: $!\n";
+	open OPTF, '<', $optfile or die "Can't open $optfile: $!\n";
 	my @opts;
 	chomp(my $line = <OPTF>);
 	my @vars = split(/\t+~\t+/, $line);
@@ -43,7 +43,7 @@ while (@{$optref} && $optref->[0] =~ /^([\w_]+)=(.*)$/) {
 my $pl_h = '../patchlevel.h';
 
 if (-e $pl_h) {
-    open PL, "<$pl_h" or die "Can't open $pl_h: $!";
+    open PL, '<', $pl_h or die "Can't open $pl_h: $!";
     while (<PL>) {
 	if (/^#\s*define\s+(PERL_\w+)\s+([\d.]+)/) {
 	    $opt{$1} = $2;

NetWare/t/NWModify.pl

@@ -85,7 +85,7 @@ sub Process_File
 	# Do the processing only if the file has '.t' extension.
 	if($ext eq '.t') {
 
-		open(FH, "+< $FileToProcess") or die "Unable to open the file,  $FileToProcess  for reading and writing.\n";
+		open(FH, '+<', $FileToProcess) or die "Unable to open the file,  $FileToProcess  for reading and writing.\n";
 		@ARRAY = <FH>;	# Get the contents of the file into an array.
 
 		foreach $Line(@ARRAY)	# Get each line of the file.

NetWare/t/NWScripts.pl

@@ -30,7 +30,7 @@
 		# Open once in write mode since later files are opened in append mode,
 		# and if there already exists a file with the same name, all further opens
 		# will append to that file!!
-		open(FHW, "> $IntAutoScript") or die "Unable to open the file,  $IntAutoScript  for writing.\n";
+		open(FHW, '>', $IntAutoScript) or die "Unable to open the file,  $IntAutoScript  for writing.\n";
 		seek(FHW, 0, 0);	# seek to the beginning of the file.
 		close FHW;			# close the file.
 	}
@@ -39,7 +39,7 @@
 
 print "Generating  t/nwauto.pl ...\n\n\n";
 
-open(FHWA, "> t/nwauto.pl") or die "Unable to open the file,  t/nwauto.pl  for writing.\n";
+open(FHWA, '>', 't/nwauto.pl') or die "Unable to open the file,  t/nwauto.pl  for writing.\n";
 seek(FHWA, 0, 0);	# seek to the beginning of the file.
 
 $version = sprintf("%vd",$^V);
@@ -67,7 +67,7 @@
 		}
 
 		# Write into the intermediary auto script.
-		open(FHW, ">> $IntAutoScript") or die "Unable to open the file,  $IntAutoScript  for appending.\n";
+		open(FHW, '>>', $IntAutoScript) or die "Unable to open the file,  $IntAutoScript  for appending.\n";
 		seek(FHW, 0, 2);	# seek to the end of the file.
 
 		$pos = tell(FHW);
@@ -164,7 +164,7 @@
 			$IntAutoScript = "t/".$DirItem.".pl";
 
 			# Write into the intermediary auto script.
-			open(FHW, ">> $IntAutoScript") or die "Unable to open the file,  $IntAutoScript  for appending.\n";
+			open(FHW, '>>', $IntAutoScript) or die "Unable to open the file,  $IntAutoScript  for appending.\n";
 			seek(FHW, 0, 2);	# seek to the end of the file.
 
 			# Write into the intermediary auto script.

Porting/Maintainers.pm

@@ -22,7 +22,7 @@ use vars qw(@ISA @EXPORT_OK $VERSION);
 		show_results process_options files_to_modules
 		finish_tap_output
 		reload_manifest);
-$VERSION = 0.11;
+$VERSION = 0.12;
 
 require Exporter;
 
@@ -41,7 +41,7 @@ sub reload_manifest {
         $manifest_path = "../MANIFEST";
     }
 
-    if (open(my $manfh,  $manifest_path )) {
+    if (open(my $manfh,  '<', $manifest_path )) {
 	while (<$manfh>) {
 	    if (/^(\S+)/) {
 		$MANIFEST{$1}++;

Porting/add-package.pl

@@ -374,7 +374,7 @@
 ### update the manifest
 {   my $file        = $Repo . '/MANIFEST';
     my @manifest;
-    {   open my $fh, "<$file" or die "Could not open $file: $!";
+    {   open my $fh, '<', $file or die "Could not open $file: $!";
         @manifest    = <$fh>;
         close $fh;
     }
@@ -414,7 +414,7 @@
     push @manifest, values %pkg_files;
 
     {   chmod 0644, $file;
-        open my $fh, ">$file" or die "Could not open $file for writing: $!";
+        open my $fh, '>', $file or die "Could not open $file for writing: $!";
         #print $fh sort { lc $a cmp lc $b } @manifest;
         ### XXX stolen from pod/buildtoc:sub do_manifest
         print $fh

Porting/check83.pl

@@ -45,7 +45,7 @@ sub eight_dot_three {
 
 my %dir;
 
-if (open(MANIFEST, "MANIFEST")) {
+if (open(MANIFEST, '<', 'MANIFEST')) {
     while (<MANIFEST>) {
 	chomp;
 	s/\s.+//;

Porting/checkAUTHORS.pl

@@ -215,7 +215,7 @@ sub read_authors_files {
     return unless (@authors);
     my (%count, %raw);
     foreach my $filename (@authors) {
-        open FH, "<$filename" or die "Can't open $filename: $!";
+        open FH, '<', $filename or die "Can't open $filename: $!";
         binmode FH, ':encoding(UTF-8)';
         while (<FH>) {
             next if /^\#/;
@@ -661,6 +661,7 @@ sub _raw_address {
 jbuehler\100hekimian.com                jhpb\100hekimian.com
 jcromie\100100divsol.com                jcromie\100cpan.org
 +                                       jim.cromie\100gmail.com
+jd\100cpanel.net                        lightsey\100debian.org
 jdhedden\100cpan.org                    jerry\100hedden.us
 +                                       jdhedden\1001979.usna.com
 +                                       jdhedden\100gmail.com

Porting/checkVERSION.pl

@@ -24,7 +24,7 @@ sub parse_file {
 
     my $result;
 
-    open(FH,$parsefile) or warn "Could not open '$parsefile': $!";
+    open(FH,'<',$parsefile) or warn "Could not open '$parsefile': $!";
 
     my $inpod = 0;
     while (<FH>) {

Porting/checkansi.pl

@@ -50,7 +50,7 @@
 find(sub {
   /\.([ch]|xs)$/ or return;
 
-  my $fh = IO::File->new($_) or die "$_: $!\n";
+  my $fh = IO::File->new($_, 'r') or die "$_: $!\n";
   my $ll = '';
 
   while (defined(my $line = <$fh>)) {

Porting/checkcfguse.pl

@@ -47,7 +47,7 @@
   print STDERR "$0: Looking for symbols...\n";
   for my $pat (@PAT) {
     for my $fn (map { glob($_) } @{ $pat->[0] }) {
-      if (open(my $fh, $fn)) {
+      if (open(my $fh, '<', $fn)) {
         while (<$fh>) {
           for my $p (@$pat) {
             for my $sym (/$p/g) {
@@ -70,7 +70,7 @@
 
 my $SYM = join("|", sort { length($b) <=> length($a) || $a cmp $b } keys %SYM);
 
-open(my $mani, "MANIFEST") or die "$0: Failed to open MANIFEST\n";
+open(my $mani, '<', "MANIFEST") or die "$0: Failed to open MANIFEST\n";
 
 my %found;
 while (<$mani>) {
@@ -80,7 +80,7 @@
     # from metaconfig generated files that refer to
     # the config symbols, and from pods.
     next if $fn =~ m{^(?:config_h.SH|Configure|configure\.com|Porting/(?:config|Glossary)|(?:NetWare|plan9|win32)/(?:config|(?:GNU)?[Mm]akefile)|uconfig)|\.pod$};
-    open my $fh, $fn or die qq[$0: Failed to open $fn: $!];
+    open my $fh, '<', $fn or die qq[$0: Failed to open $fn: $!];
     while (<$fh>) {
       while (/\b($SYM)\b/go) {
         $found{$1}{$fn}++;

Porting/config_h.pl

@@ -15,7 +15,7 @@
 use warnings;
 
 my ($cSH, $ch, @ch, %ch) = ("config_h.SH");
-open $ch, "<$cSH" or die "Cannot open $cSH: $!\n";
+open $ch, '<', $cSH or die "Cannot open $cSH: $!\n";
 {   local $/ = "\n\n";
     @ch = <$ch>;
     close  $ch;
@@ -68,7 +68,7 @@ ()
 push @ch, ";;\nesac\n";
 
 
-open  $ch, "> $cSH" or die "Cannot write $cSH: $!\n";
+open  $ch, '>', $cSH or die "Cannot write $cSH: $!\n";
 print $ch <<EOW;
 #!/bin/sh
 #

Porting/corecpan.pl

@@ -58,7 +58,7 @@ ()
 
 # Load the package details. All of them.
 my %cpanversions;
-open my $fh, $packagefile or die $!;
+open my $fh, '<', $packagefile or die $!;
 while (<$fh>) {
     my ($p, $v) = split ' ';
     next if 1../^\s*$/; # skip header

Porting/leakfinder.pl

@@ -31,9 +31,9 @@
          =~ s/\0/'."\\0".'/grid;
     $prog = <<end;   
             open oUt, ">&", STDOUT;
-            open STDOUT, ">/dev/null";
-            open STDIN, "</dev/null";
-            open STDERR, ">/dev/null";
+            open STDOUT, ">", "/dev/null";
+            open STDIN, "<", "/dev/null";
+            open STDERR, ">", "/dev/null";
             \$unused_variable = '$q';
             eval \$unused_variable while \$also_unused++ < 4;
             print oUt sv_count, "\n";

Porting/makerel

@@ -48,7 +48,7 @@ $relroot = defined $opts{r} ? $opts{r} : "..";
 die "Must be in root of the perl source tree.\n"
 	unless -f "./MANIFEST" and -f "patchlevel.h";
 
-open PATCHLEVEL,"<patchlevel.h" or die;
+open PATCHLEVEL, '<', 'patchlevel.h' or die;
 my @patchlevel_h = <PATCHLEVEL>;
 close PATCHLEVEL;
 my $patchlevel_h = join "", grep { /^#\s*define/ } @patchlevel_h;

Porting/manicheck

@@ -8,7 +8,7 @@ use strict;
 use warnings;
 use File::Find;
 
-open my $fh, 'MANIFEST' or die "Can't read MANIFEST: $!\n";
+open my $fh, '<', 'MANIFEST' or die "Can't read MANIFEST: $!\n";
 my @files = map { (split)[0] } <$fh>;
 close $fh;
 for (@files) {

Porting/sync-with-cpan

@@ -290,7 +290,7 @@ Archive::Tar->extract_archive( $new_file );
 # ensure 'make' will update all files
 my $t= time;
 for my $file (find_type_f($new_dir)) {
-    open(my $fh,">>$file") || die "Cannot write $file:$!";
+    open(my $fh,'>>',$file) || die "Cannot write $file:$!";
     close($fh);
     utime($t,$t,$file);
 };

autodoc.pl

@@ -355,7 +355,7 @@ sub output {
 while (my $line = <$fh>) {
     next unless my ($file) = $line =~ /^(\S+\.[ch])\t/;
 
-    open F, "< $file" or die "Cannot open $file for docs: $!\n";
+    open F, '<', $file or die "Cannot open $file for docs: $!\n";
     $curheader = "Functions in file $file\n";
     autodoc(\*F,$file);
     close F or die "Error closing $file: $!\n";

charclass_invlists.h

@@ -91515,7 +91515,7 @@ static const U8 WB_table[24][24] = {
 #endif	/* defined(PERL_IN_REGEXEC_C) */
 
 /* Generated from:
- * f1951e655fd5fa35478f641663ef164146d743362998b01378327afac5f20270 lib/Unicode/UCD.pm
+ * 59e717586b720a821ee0d7397679d5322e38b49f6fb7840545aedf669c733b70 lib/Unicode/UCD.pm
  * 47cb62a53beea6d0263e2147331c7e751853c9327225d95bbe2d9e1dc3e1aa44 lib/unicore/ArabicShaping.txt
  * 153f0a100c315f9f3945e78f57137611d36c44b3a975919c499fd403413fede8 lib/unicore/BidiBrackets.txt
  * fbe806975c1bf9fc9960bbaa39ff6290c42c7da8315f9cd459109b024cc1c485 lib/unicore/BidiMirroring.txt
@@ -91561,5 +91561,5 @@ static const U8 WB_table[24][24] = {
  * 066d6e75f95cf6794161c8ac0b1a40990277de90eefb913be2e675a7cba38d59 lib/unicore/mktables
  * cdecb300baad839a6f62791229f551a4fa33f3cbdca08e378dc976466354e778 lib/unicore/version
  * 913d2f93f3cb6cdf1664db888bf840bc4eb074eef824e082fceda24a9445e60c regen/charset_translations.pl
- * 6697977221bf632720408ca9a1a934e43d5d8e51c870532cec3ebdb3e3ba80c6 regen/mk_invlists.pl
+ * ed40040566a4f1d6b0d912dda2159c1460e0093b318d90626ab9aa513a53b15d regen/mk_invlists.pl
  * ex: set ro: */

configpm

@@ -216,7 +216,7 @@ my $quote;
 my %seen_quotes;
 {
   my ($name, $val);
-  open(CONFIG_SH, $Config_SH) || die "Can't open $Config_SH: $!";
+  open(CONFIG_SH, '<', $Config_SH) || die "Can't open $Config_SH: $!";
   while (<CONFIG_SH>) {
     next if m:^#!/bin/sh:;
 
@@ -527,7 +527,7 @@ $heavy_txt .= join('', @non_v) . "\n";
 
 # copy config summary format from the myconfig.SH script
 $heavy_txt .= "our \$summary = <<'!END!';\n";
-open(MYCONFIG,"<myconfig.SH") || die "open myconfig.SH failed: $!";
+open(MYCONFIG,'<','myconfig.SH') || die "open myconfig.SH failed: $!";
 1 while defined($_ = <MYCONFIG>) && !/^Summary of/;
 do { $heavy_txt .= $_ } until !defined($_ = <MYCONFIG>) || /^\s*$/;
 close(MYCONFIG);
@@ -632,7 +632,7 @@ foreach my $prefix (qw(libs libswanted)) {
     $heavy_txt .= "${prefix}_nolargefiles='$value'\n";
 }
 
-if (open(my $fh, "cflags")) {
+if (open(my $fh, '<', 'cflags')) {
     my $ccwarnflags;
     my $ccstdflags;
     while (<$fh>) {
@@ -838,7 +838,7 @@ tie %%Config, 'Config', {
 ENDOFTIE
 
 
-open(CONFIG_POD, ">$Config_POD") or die "Can't open $Config_POD: $!";
+open(CONFIG_POD, '>', $Config_POD) or die "Can't open $Config_POD: $!";
 print CONFIG_POD <<'ENDOFTAIL';
 =head1 NAME
 
@@ -991,7 +991,7 @@ in such cases.
 ENDOFTAIL
 
 if ($Opts{glossary}) {
-  open(GLOS, "<$Glossary") or die "Can't open $Glossary: $!";
+  open(GLOS, '<', $Glossary) or die "Can't open $Glossary: $!";
 }
 my %seen = ();
 my $text = 0;

dist/Devel-SelfStubber/lib/Devel/SelfStubber.pm

@@ -4,7 +4,7 @@ require SelfLoader;
 @ISA = qw(SelfLoader);
 @EXPORT = 'AUTOLOAD';
 $JUST_STUBS = 1;
-$VERSION = 1.05;
+$VERSION = 1.06;
 sub Version {$VERSION}
 
 # Use as
@@ -39,7 +39,7 @@ sub stub {
     my (@BEFORE_DATA, @AFTER_DATA, @AFTER_END);
     @DATA = @STUBS = ();
 
-    open($fh,$mod_file) || die "Unable to open $mod_file";
+    open($fh,'<',$mod_file) || die "Unable to open $mod_file";
     local $/ = "\n";
     while(defined ($line = <$fh>) and $line !~ m/^__DATA__/) {
 	push(@BEFORE_DATA,$line);