Fatalization of calling import/unimport method with argument

This commit is mostly a manual reversion of commit f1cf82e.  Return to
using a perl_croak in universal.c; adjust regen/warnings.pl as needed; run 'make
regen'; get t/op/universal.t passing.  No documentation changes yet.

Add test for undefined unimport method, then refactor repeated code into
a subroutine.  Perform a pattern match rather than a string equality
test because testing for exact line numbers inside a test program is too
fragile for maintenance purposes.

'mispelled' was misspelled in one location; correct.  Suppress 'used
only once' warning in one location.  POD formatting improvements as
suggested by Elvin Aslanov, with one other word change.

Correct case of one character in error message so that it's the same in
both universal.c and pod/perldiag.pod.  This enables us to preserve
status of universal.c in t/porting/diag.t.  Per: Tony Cook review.

For: GH #23623

Author: jkeenan

lib/warnings.pm

@@ -1339,20 +1339,14 @@ a string overload and is also not a blessed CODE reference. In short the
 C<require> function does not know what to do with the object.
 See also L<perlfunc/require>.
 
-=item Attempt to call undefined %s method with arguments ("%s"%s)
-via package "%s" (Perhaps you forgot to load the package?)
-
-(D deprecated::missing_import_called_with_args) You called the
-C<import()> or C<unimport()> method of a class that has no import method
-defined in its inheritance graph, and passed an argument to the method.
-This is very often the sign of a misspelled package name in a use or
-require statement that has silently succeded due to a case insensitive
-file system.
+=item Attempt to call undefined %s method with arguments via package
+"%s" (Perhaps you forgot to load the package?)
 
-Another common reason this may happen is when mistakenly attempting to
-import or unimport a symbol from a class definition or package which
-does not use C<Exporter> or otherwise define its own C<import> or
-C<unimport> method.
+(F) You called the C<import()> or C<unimport()> method of a class that has no
+such method defined in its inheritance graph, and passed an argument to the
+method. This is very often the sign of a misspelled package name in a C<use>
+or C<require> statement that has silently succeded due to a case insensitive
+file system.
 
 =item Can't locate package %s for @%s::ISA
 

pod/perldiag.pod

@@ -16,7 +16,7 @@
 #
 # This script is normally invoked from regen.pl.
 
-$VERSION = '1.75';
+$VERSION = '1.76';
 
 BEGIN {
     require './regen/regen_lib.pl';
@@ -189,6 +189,7 @@ BEGIN
 # the experiments were successful (or abandoned),
 # so no warning bit is needed anymore
 my %NO_BIT_FOR = map { ( uc $_ => 1, $_ => 1 ) } qw(
+  deprecated::missing_import_called_with_args
   deprecated::smartmatch
   experimental::lexical_subs
   experimental::postderef

regen/warnings.pl

@@ -196,25 +196,28 @@ my $x = {}; bless $x, 'X';
 ok $x->isa('UNIVERSAL');
 ok $x->isa('UNIVERSAL');
 
-
-{
-    my $err;
-    $SIG{__WARN__}= sub { die $_[0] };
-    eval { Some::Package->import("bar") };
-    my $err = $@;
-    $err=~s!t/op!op!;
-    is $err, "Attempt to call undefined import method with arguments (\"bar\")"
-           . " via package \"Some::Package\" (Perhaps you forgot to load"
-           . " the package?) at op/universal.t line 203.\n";
-    eval { Some::Package->unimport(1.234) };
-    $err = $@;
+sub test_undefined_method {
+    my $method = shift;
+    my @message_components = (
+        q|Attempt to call undefined|,
+        q|method with arguments via package "Some::Package"|,
+        q|(Perhaps you forgot to load the package?)|,
+    );
+    eval { Some::Package->$method("bar") };
+    my $err= $@;
     $err=~s!t/op!op!;
-    is $err, "Attempt to call undefined unimport method with arguments (\"1.234\")"
-           . " via package \"Some::Package\" (Perhaps you forgot to load"
-           . " the package?) at op/universal.t line 209.\n";
-
+    my $message = join ' ' => (
+        $message_components[0],
+        $method,
+        @message_components[1,2],
+    );
+    my $pattern = qr/\Q$message\E/;
+    like $err, $pattern, "Got expected pattern for undefined $method";
 }
 
+test_undefined_method('import');
+test_undefined_method('unimport');
+
 # This segfaulted in a blead.
 fresh_perl_is('package Foo; Foo->VERSION;  print "ok"', 'ok');
 

t/op/universal.t

@@ -137,6 +137,7 @@ while (<$diagfh>) {
                                     && !$entries{$cur_entry}{cattodo}) {
         my $data_line= $entries{$cur_entry}{todo_line};
         TODO: {
+            no warnings 'once';
             local $::TODO = "Remove the TODO entry \"$cur_entry\" from DATA "
                           . "at $0 line $data_line as it is already in $pod near line $.";
             ok($cur_entry);

t/porting/diag.t

@@ -451,14 +451,10 @@ XS(XS_UNIVERSAL_import_unimport)
          * depends on it has its own "no import" logic that produces better
          * warnings than this does. */
         if (strNE(class_pv,"_charnames"))
-            ck_warner_d(packWARN(WARN_DEPRECATED__MISSING_IMPORT_CALLED_WITH_ARGS),
-                        "Attempt to call undefined %s method with arguments "
-                        "(%" SVf_QUOTEDPREFIX "%s) via package "
-                        "%" SVf_QUOTEDPREFIX " (Perhaps you forgot to load the package?)",
-                        ix ? "unimport" : "import",
-                        SVfARG(ST(1)),
-                        (items > 2 ? " ..." : ""),
-                        SVfARG(ST(0)));
+            Perl_croak(aTHX_
+                "Attempt to call undefined %s method with arguments via package "
+                 "%" SVf_QUOTEDPREFIX " (Perhaps you forgot to load the package?)",
+                ix ? "unimport" : "import", SVfARG(ST(0)));
     }
     XSRETURN_EMPTY;
 }