feat: add firecrawl template#363
Merged
Marvin-Cypher merged 1 commit intoMay 27, 2026
Merged
Conversation
Contributor
Author
|
cc @Marvin-Cypher for review. |
9b49e50 to
1872e99
Compare
Marvin-Cypher
approved these changes
May 27, 2026
Contributor
Marvin-Cypher
left a comment
There was a problem hiding this comment.
Reviewed template files, normalized tags, compose config, config validation, stale path cleanup, and compose safety scan. Checks are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
firecrawlprebuilt template forfirecrawl/firecrawl.img/firecrawl_logo.pngastemplates/icons/firecrawl.png.Template files
templates/prebuilt/firecrawl/docker-compose.ymltemplates/prebuilt/firecrawl/README.mdtemplates/icons/firecrawl.pngtemplates/config.jsonUpstream
c5bb852969f7a88ecaf5a213567872bcf0c6a2eaimg/firecrawl_logo.pngfrom the pinned upstream repoEnvironment variables
FIRECRAWL_UPSTREAM_TIMEOUT_SECONDS(optional, default5)FIRECRAWL_VERIFY_ON_STARTUP(optional, defaulttrue)No credentials are required for the default smoke path.
Validation
python3 sdks/templates/validate.py✅git -C sdks diff --check origin/main...HEAD✅docker compose -f sdks/templates/prebuilt/firecrawl/docker-compose.yml config >/dev/null✅env_file, external build context, Docker socket, privileged mode, or real secrets.Phala Cloud deployment smoke
hermes-admin-cvm-check/h4x's projectsphala deploy --name auto-template-test-firecrawl-0527-090601 --compose sdks/templates/prebuilt/firecrawl/docker-compose.yml --instance-type tdx.small --wait --no-public-logs --no-public-sysinfo --json5f840e5dfcdd89694c300fd59f2ac0f680dec4af8be304f4-a272-408e-9780-25d0158cbc11phala psshowed/dstack-app-1running with statusUp ... (healthy).8080:GET /healthz→ HTTP 200,status=ok, upstream verificationverifiedGET /demo→ HTTP 200, 4 deterministic examplesGET /v1/models→ HTTP 200, 1 smoke model entryGET /upstream→ HTTP 200, 4 pinned files verifiedCleanup
cvm_MeD0MVeQwas deleted withphala cvms delete --force.not found/ deleted state. ✅cc @Marvin-Cypher for review.