feat: add llamafactory template#365
Merged
Marvin-Cypher merged 1 commit intoMay 27, 2026
Merged
Conversation
Contributor
Author
|
cc @Marvin-Cypher for review. |
0663ad2 to
c45b0dd
Compare
Marvin-Cypher
approved these changes
May 27, 2026
Contributor
Marvin-Cypher
left a comment
There was a problem hiding this comment.
Reviewed template files, normalized tags, compose config, config validation, stale path cleanup, and compose safety scan. Checks are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llamafactoryprebuilt template forhiyouga/LlamaFactory.templates/icons/llamafactory.png.Upstream
assets/logo.pngfrom the README/treeTemplate files
templates/prebuilt/llamafactory/docker-compose.ymltemplates/prebuilt/llamafactory/README.mdtemplates/icons/llamafactory.pngtemplates/config.jsonEnvironment variables
LLAMAFACTORY_REF(optional, defaultv0.9.4): upstream Git tag, commit, or simple branch ref used by the verifier.No credentials are required for the default smoke demo. README documents optional production env vars such as
HF_TOKEN,WANDB_API_KEY,SWANLAB_API_KEY,API_KEY,MODEL_NAME_OR_PATH, andDATASETwithout real secret values.Validation
python3 sdks/templates/validate.py✅git -C sdks diff --check origin/main...HEAD✅docker compose -f sdks/templates/prebuilt/llamafactory/docker-compose.yml config >/tmp/llamafactory-compose-config.out✅env_file, externalbuild, host bind mounts, Docker socket, host networking, host IPC directive, privileged mode, or literal secretsRuntime smoke
Local direct Python verifier smoke (without Docker daemon) ✅
/healthzreturnedok=true,status=readyv0.9.4, LlamaFactory version0.9.4/demoreturnedok=true/v1/modelsreturned OpenAI-compatible empty model listPhala Cloud deployment smoke ✅
hermes-admin-cvm-checktdx.smallauto-template-test-llamafactory-0527-115548206df375-da1d-41da-b7a8-0c6a832d66558f332823a9623230822f1fb94b33cafb910b7f1bphala psshowed/dstack-app-1running and healthyhttps://8f332823a9623230822f1fb94b33cafb910b7f1b-8080.dstack-pha-prod7.phala.networkGET /healthzHTTP 200 withok=true,status=ready,source_check.errors=[]GET /demoHTTP 200 withok=true,cpu_only=trueGET /v1/modelsHTTP 200 withobject=list,data=[]Cleanup