Skip to content

chore(terraform): bump submodule to Go SDK migration head#278

Open
Leechael wants to merge 1 commit into
mainfrom
chore/terraform-bump-go-sdk-migration
Open

chore(terraform): bump submodule to Go SDK migration head#278
Leechael wants to merge 1 commit into
mainfrom
chore/terraform-bump-go-sdk-migration

Conversation

@Leechael
Copy link
Copy Markdown
Collaborator

Summary

Bumps the terraform/ submodule pointer from 47dcd99 (orphaned — old PR #4 head before force-push) to d7a9414 (current head of refactor/use-go-sdk in terraform-provider-phala#4).

What this picks up

The terraform PR was rebased onto terraform main + force-pushed, absorbing every feature that landed since the PR was first opened in March, all now wired through the Go SDK (github.com/Phala-Network/phala-cloud/sdks/go):

  • Per-instance state under phala_app.instances (was cccccf1 on terraform main)
  • MIG named-slot mode via phala_app_instance + phala_app.members (626cfb2)
  • ValidateConfig members invariants (46cf1c3)
  • ModifyPlan members-mode guardrail (36181d5)
  • Per-instance env support on phala_app_instance (c08da9e)
  • Stable primary selection by phala_app.name (e52e015)
  • In-place env updates with diff detection (b7575aa) — closes #246
  • phala_app_preflight resource + data source (52585a4)
  • BREAKING: replicas-based scaling removed (89c413b)
  • All API calls now flow through typed SDK methods; structured APIError codes/suggestions surface in Terraform diagnostics

The migration commit deletes ~37k lines of duplicated client code (oapi-codegen output + hand-rolled APIClient/cvmAPIResponse).

Supersedes

Caveats

  • d7a9414 is the head of an unmerged PR branch. Re-bump this pointer to the squash-merge commit once terraform-provider-phala#4 lands on its main.
  • The Go SDK still has no public Go-module-proxy-resolvable tag at sdks/go/v0.x.y (the existing sdks/go/v0.1.1 predates the go/sdks/go/ directory rename and isn't fetchable). Until a new tag, terraform provider CI relies on the sparse-checkout dance documented in terraform/.github/workflows/.

Test plan

  • git submodule update --init terraform resolves cleanly to d7a9414
  • terraform PR Add api version header #4 itself shows MERGEABLE (no conflicts) and CI green on its branch
  • sanity-check fresh-clone submodule init after merge

Points terraform/ at d7a9414 (refactor/use-go-sdk in
Phala-Network/terraform-provider-phala#4 after the
2026-05 force-push).

The previously recorded commit 47dcd99 was the head of PR #4 before
it was rebased onto terraform main + force-pushed to absorb every
feature that landed since the PR was first opened (per-instance
state under phala_app.instances, MIG named-slot via
phala_app_instance, ValidateConfig members invariants,
ModifyPlan members-mode guardrail, stable primary selection,
in-place env updates with diff detection, replicas-drop break,
preflight resource), all now wired through the Go SDK.

Supersedes #248: that PR bumped to v0.2.0-beta.3 (40716e8) before
the SDK migration was rebased. Close #248 when this merges; the
Go SDK head subsumes the env-update fix.

Note: d7a9414 is the head of an unmerged PR branch. The pointer
should be re-bumped to the squash-merge commit once
terraform-provider-phala#4 lands on main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

phala_app: in-place env updates aren't applied — provider reports 'No changes' despite changed values

1 participant