Remove outdated ignores (flutter#162773)

Powered by the new and amazing `unnecessary_ignore` lint.

We're not enabling this lint by default because being able to
temporarily use ignores that don't ignore anything is a powerful tool to
enable migrations. We should turn this lint on locally periodically,
though, and clean up all outdated ignores.

Author: goderbauer

analysis_options.yaml

@@ -223,6 +223,7 @@ linter:
     - unnecessary_constructor_name
     # - unnecessary_final # conflicts with prefer_final_locals
     - unnecessary_getters_setters
+    # - unnecessary_ignore # Disabled by default to simplify migrations; should be periodically enabled locally to clean up offenders
     # - unnecessary_lambdas # has false positives: https://github.com/dart-lang/linter/issues/498
     - unnecessary_late
     - unnecessary_library_directive

dev/a11y_assessments/test/home_page_test.dart

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: avoid_dynamic_calls
-
 import 'package:a11y_assessments/main.dart';
 import 'package:a11y_assessments/use_cases/action_chip.dart';
 import 'package:a11y_assessments/use_cases/auto_complete.dart';

dev/devicelab/bin/tasks/build_android_host_app_with_module_aar.dart

@@ -437,7 +437,6 @@ class ModuleTest {
 Future<void> main() async {
   await task(
     combine(<TaskFunction>[
-      // ignore: avoid_redundant_argument_values
       ModuleTest(gradleVersion: '8.4').call,
       ModuleTest(gradleVersion: '8.4-rc-3').call,
     ]),

dev/devicelab/bin/tasks/build_android_host_app_with_module_source.dart

@@ -407,10 +407,5 @@ class ModuleTest {
 }
 
 Future<void> main() async {
-  await task(
-    combine(<TaskFunction>[
-      // ignore: avoid_redundant_argument_values
-      ModuleTest(gradleVersion: '8.7').call,
-    ]),
-  );
+  await task(combine(<TaskFunction>[ModuleTest(gradleVersion: '8.7').call]));
 }

dev/integration_tests/display_cutout_rotation/test_driver/display_cutout_test_test.dart

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: avoid_print
-
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';

dev/integration_tests/link_hook/lib/link_hook_bindings_generated.dart

@@ -2,10 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: always_specify_types
-// ignore_for_file: camel_case_types
-// ignore_for_file: non_constant_identifier_names
-
 // AUTO GENERATED FILE, DO NOT EDIT.
 //
 // Generated by `package:ffigen`.

dev/integration_tests/new_gallery/lib/data/demos.dart

@@ -1036,11 +1036,7 @@ class Demos {
             description: localizations.demoCupertinoPickerDescription,
             documentationUrl: '$_docsBaseUrl/cupertino/CupertinoDatePicker-class.html',
             buildRoute:
-                (_) => DeferredWidget(
-                  cupertinoLoader,
-                  // ignore: prefer_const_constructors
-                  () => cupertino_demos.CupertinoPickerDemo(),
-                ),
+                (_) => DeferredWidget(cupertinoLoader, () => cupertino_demos.CupertinoPickerDemo()),
           ),
         ],
         category: GalleryDemoCategory.cupertino,
@@ -1056,11 +1052,8 @@ class Demos {
             description: localizations.demoCupertinoScrollbarDescription,
             documentationUrl: '$_docsBaseUrl/cupertino/CupertinoScrollbar-class.html',
             buildRoute:
-                (_) => DeferredWidget(
-                  cupertinoLoader,
-                  // ignore: prefer_const_constructors
-                  () => cupertino_demos.CupertinoScrollbarDemo(),
-                ),
+                (_) =>
+                    DeferredWidget(cupertinoLoader, () => cupertino_demos.CupertinoScrollbarDemo()),
           ),
         ],
         category: GalleryDemoCategory.cupertino,

dev/integration_tests/new_gallery/lib/routes.dart

@@ -55,45 +55,32 @@ class RouteConfiguration {
     ),
     Path(
       r'^' + rally_routes.homeRoute,
-      (BuildContext context, String? match) => StudyWrapper(
-        study: DeferredWidget(
-          rally.loadLibrary,
-          () => rally.RallyApp(),
-        ), // ignore: prefer_const_constructors
-      ),
+      (BuildContext context, String? match) =>
+          StudyWrapper(study: DeferredWidget(rally.loadLibrary, () => rally.RallyApp())),
     ),
     Path(
       r'^' + shrine_routes.homeRoute,
-      (BuildContext context, String? match) => StudyWrapper(
-        study: DeferredWidget(
-          shrine.loadLibrary,
-          () => shrine.ShrineApp(),
-        ), // ignore: prefer_const_constructors
-      ),
+      (BuildContext context, String? match) =>
+          StudyWrapper(study: DeferredWidget(shrine.loadLibrary, () => shrine.ShrineApp())),
     ),
     Path(
       r'^' + crane_routes.defaultRoute,
       (BuildContext context, String? match) => StudyWrapper(
         study: DeferredWidget(
           crane.loadLibrary,
-          () => crane.CraneApp(), // ignore: prefer_const_constructors
+          () => crane.CraneApp(),
           placeholder: const DeferredLoadingPlaceholder(name: 'Crane'),
         ),
       ),
     ),
     Path(
       r'^' + fortnightly_routes.defaultRoute,
       (BuildContext context, String? match) => StudyWrapper(
-        study: DeferredWidget(
-          fortnightly.loadLibrary,
-          // ignore: prefer_const_constructors
-          () => fortnightly.FortnightlyApp(),
-        ),
+        study: DeferredWidget(fortnightly.loadLibrary, () => fortnightly.FortnightlyApp()),
       ),
     ),
     Path(
       r'^' + reply_routes.homeRoute,
-      // ignore: prefer_const_constructors
       (BuildContext context, String? match) =>
           const StudyWrapper(study: reply.ReplyApp(), hasBottomNavBar: true),
     ),

dev/snippets/lib/src/util.dart

@@ -263,7 +263,6 @@ SampleStats getSampleStats(SourceElement element) {
 
 /// Exit the app with a message to stderr.
 /// Can be overridden by tests to avoid exits.
-// ignore: prefer_function_declarations_over_variables
 void Function(String message) errorExit = (String message) {
   io.stderr.writeln(message);
   io.exit(1);

engine/src/flutter/lib/ui/geometry.dart

@@ -357,7 +357,7 @@ class Size extends OffsetBase {
   ///
   ///  * [Size.fromRadius], which is more convenient when the available size
   ///    is the radius of a circle.
-  const Size.square(double dimension) : super(dimension, dimension); // ignore: use_super_parameters
+  const Size.square(double dimension) : super(dimension, dimension);
 
   /// Creates a [Size] with the given [width] and an infinite [height].
   const Size.fromWidth(double width) : super(width, double.infinity);

engine/src/flutter/lib/ui/natives.dart

@@ -3,8 +3,6 @@
 // found in the LICENSE file.
 part of dart.ui;
 
-// ignore_for_file: avoid_classes_with_only_static_members
-
 /// Helper functions for Dart Plugin Registrants.
 abstract final class DartPluginRegistrant {
   static bool _wasInitialized = false;

engine/src/flutter/lib/web_ui/dev/firefox.dart

@@ -7,8 +7,7 @@ import 'dart:io';
 
 import 'package:path/path.dart' as path;
 import 'package:test_api/backend.dart';
-// TODO(ditman): Fix ignore when https://github.com/flutter/flutter/issues/143599 is resolved.
-import 'package:test_core/src/util/io.dart'; // ignore: implementation_imports
+import 'package:test_core/src/util/io.dart';
 
 import 'browser.dart';
 import 'browser_process.dart';

engine/src/flutter/lib/web_ui/dev/steps/run_suite_step.dart

@@ -10,10 +10,8 @@ import 'package:path/path.dart' as pathlib;
 //                https://github.com/dart-lang/test/issues/1521
 import 'package:skia_gold_client/skia_gold_client.dart';
 import 'package:test_api/backend.dart' as hack;
-// TODO(ditman): Fix ignores when https://github.com/flutter/flutter/issues/143599 is resolved.
-import 'package:test_core/src/executable.dart' as test; // ignore: implementation_imports
-import 'package:test_core/src/runner/hack_register_platform.dart'
-    as hack; // ignore: implementation_imports
+import 'package:test_core/src/executable.dart' as test;
+import 'package:test_core/src/runner/hack_register_platform.dart' as hack;
 
 import '../browser.dart';
 import '../common.dart';

engine/src/flutter/lib/web_ui/dev/test_platform.dart

@@ -23,13 +23,12 @@ import 'package:skia_gold_client/skia_gold_client.dart';
 import 'package:stream_channel/stream_channel.dart';
 
 import 'package:test_core/backend.dart' hide Compiler;
-// TODO(ditman): Fix ignores when https://github.com/flutter/flutter/issues/143599 is resolved.
-import 'package:test_core/src/runner/environment.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/platform.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/plugin/platform_helpers.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/runner_suite.dart'; // ignore: implementation_imports
-import 'package:test_core/src/util/io.dart'; // ignore: implementation_imports
-import 'package:test_core/src/util/stack_trace_mapper.dart'; // ignore: implementation_imports
+import 'package:test_core/src/runner/environment.dart';
+import 'package:test_core/src/runner/platform.dart';
+import 'package:test_core/src/runner/plugin/platform_helpers.dart';
+import 'package:test_core/src/runner/runner_suite.dart';
+import 'package:test_core/src/util/io.dart';
+import 'package:test_core/src/util/stack_trace_mapper.dart';
 
 import 'package:web_socket_channel/web_socket_channel.dart';
 import 'package:web_test_utils/image_compare.dart';

engine/src/flutter/lib/web_ui/lib/geometry.dart

@@ -90,7 +90,7 @@ class Size extends OffsetBase {
   const Size(super.width, super.height);
   // Used by the rendering library's _DebugSize hack.
   Size.copy(Size source) : super(source.width, source.height);
-  const Size.square(double dimension) : super(dimension, dimension); // ignore: use_super_parameters
+  const Size.square(double dimension) : super(dimension, dimension);
   const Size.fromWidth(double width) : super(width, double.infinity);
   const Size.fromHeight(double height) : super(double.infinity, height);
   const Size.fromRadius(double radius) : super(radius * 2.0, radius * 2.0);

engine/src/flutter/lib/web_ui/lib/natives.dart

@@ -4,8 +4,6 @@
 
 part of ui;
 
-// ignore_for_file: avoid_classes_with_only_static_members
-
 /// Helper functions for Dart Plugin Registrants.
 class DartPluginRegistrant {
   /// Makes sure the that the Dart Plugin Registrant has been called for this

engine/src/flutter/lib/web_ui/lib/platform_dispatcher.dart

@@ -16,7 +16,6 @@ typedef PlatformMessageCallback =
     void Function(String name, ByteData? data, PlatformMessageResponseCallback? callback);
 typedef ErrorCallback = bool Function(Object exception, StackTrace stackTrace);
 
-// ignore: avoid_classes_with_only_static_members
 /// A token that represents a root isolate.
 class RootIsolateToken {
   static RootIsolateToken? get instance {

engine/src/flutter/lib/web_ui/lib/src/engine/canvaskit/canvaskit_api.dart

@@ -2756,30 +2756,16 @@ extension SkTextStylePropertiesExtension on SkTextStyleProperties {
 
   @JS('shadows')
   external set _shadows(JSArray<JSAny?>? value);
-  set shadows(List<SkTextShadow>? value) =>
-          // TODO(joshualitt): remove this cast when we reify JS types on JS
-          // backends.
-          // ignore: unnecessary_cast
-          _shadows =
-          (value as List<JSAny>?)?.toJS;
+  set shadows(List<SkTextShadow>? value) => _shadows = (value as List<JSAny>?)?.toJS;
 
   @JS('fontFeatures')
   external set _fontFeatures(JSArray<JSAny?>? value);
-  set fontFeatures(List<SkFontFeature>? value) =>
-          // TODO(joshualitt): remove this cast when we reify JS types on JS
-          // backends.
-          // ignore: unnecessary_cast
-          _fontFeatures =
-          (value as List<JSAny>?)?.toJS;
+  set fontFeatures(List<SkFontFeature>? value) => _fontFeatures = (value as List<JSAny>?)?.toJS;
 
   @JS('fontVariations')
   external set _fontVariations(JSArray<JSAny?>? value);
   set fontVariations(List<SkFontVariation>? value) =>
-          // TODO(joshualitt): remove this cast when we reify JS types on JS
-          // backends.
-          // ignore: unnecessary_cast
-          _fontVariations =
-          (value as List<JSAny>?)?.toJS;
+      _fontVariations = (value as List<JSAny>?)?.toJS;
 }
 
 @JS()

engine/src/flutter/lib/web_ui/lib/src/engine/dom.dart

@@ -158,7 +158,6 @@ extension DomWindowExtension on DomWindow {
         message.toJSAnyShallow,
         targetOrigin.toJS,
         // Cast is necessary so we can call `.toJS` on the right extension.
-        // ignore: unnecessary_cast
         (messagePorts as List<JSAny>).toJS,
       );
     }

engine/src/flutter/lib/web_ui/lib/src/engine/html/renderer.dart

@@ -140,8 +140,7 @@ class HtmlRenderer implements Renderer {
     required ui.ImageFilter outer,
     required ui.ImageFilter inner,
   }) {
-    // TODO(ferhat): add implementation and remove the "ignore".
-    // ignore: avoid_unused_constructor_parameters
+    // TODO(ferhat): add implementation.
     throw UnimplementedError('ImageFilter.erode not implemented for HTML renderer.');
   }
 

engine/src/flutter/lib/web_ui/lib/src/engine/safe_browser_api.dart

@@ -869,7 +869,6 @@ class GlContext {
   }
 }
 
-// ignore: avoid_classes_with_only_static_members
 /// Creates gl context from cached OffscreenCanvas for webgl rendering to image.
 class GlContextCache {
   static int _maxPixelWidth = 0;

engine/src/flutter/lib/web_ui/lib/src/engine/skwasm/skwasm_impl.dart

@@ -4,7 +4,6 @@
 
 @DefaultAsset('skwasm')
 // The web_sdk/sdk_rewriter.dart uses this directive.
-// ignore: unnecessary_library_directive
 library skwasm_impl;
 
 import 'dart:ffi';

engine/src/flutter/lib/web_ui/lib/src/engine/skwasm/skwasm_impl/vertices.dart

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: avoid_unused_constructor_parameters
-
 import 'dart:ffi';
 import 'dart:typed_data';
 

engine/src/flutter/lib/web_ui/lib/src/engine/view_embedder/dimensions_provider/custom_element_dimensions_provider.dart

@@ -74,9 +74,7 @@ class CustomElementDimensionsProvider extends DimensionsProvider {
   void close() {
     super.close();
     _hostElementResizeObserver?.disconnect();
-    // ignore:unawaited_futures
     _dprChangeStreamSubscription?.cancel();
-    // ignore:unawaited_futures
     _onResizeStreamController.close();
   }
 

engine/src/flutter/lib/web_ui/lib/src/engine/view_embedder/dimensions_provider/full_page_dimensions_provider.dart

@@ -51,7 +51,6 @@ class FullPageDimensionsProvider extends DimensionsProvider {
   void close() {
     super.close();
     _domResizeSubscription.cancel();
-    // ignore:unawaited_futures
     _onResizeStreamController.close();
   }
 

engine/src/flutter/lib/web_ui/test/common/matchers.dart

@@ -110,7 +110,7 @@ double _rectDistance(Rect a, Rect b) {
 }
 
 double _sizeDistance(Size a, Size b) {
-  final Offset delta = (b - a) as Offset; // ignore: unnecessary_parenthesis
+  final Offset delta = (b - a) as Offset;
   return delta.distance;
 }
 

engine/src/flutter/lib/web_ui/test/engine/channel_buffers_test.dart

@@ -191,7 +191,7 @@ void testMain() {
     }
 
     void twoCallback(ByteData? responseData) {
-      throw TestFailure('wrong callback called'); // ignore: only_throw_errors
+      throw TestFailure('wrong callback called');
     }
 
     _resize(buffers, channel, 100);
@@ -214,7 +214,7 @@ void testMain() {
     }
 
     void twoCallback(ByteData? responseData) {
-      throw TestFailure('wrong callback called'); // ignore: only_throw_errors
+      throw TestFailure('wrong callback called');
     }
 
     _resize(buffers, channel, 1);

engine/src/flutter/lib/web_ui/test/ui/canvas_test.dart

@@ -46,7 +46,7 @@ Future<void> testMain() async {
       } on TestFailure {
         return;
       }
-      throw TestFailure('transforms were too close to equal'); // ignore: only_throw_errors
+      throw TestFailure('transforms were too close to equal');
     }
 
     test('ui.Canvas.translate affects canvas.getTransform', () {
@@ -136,7 +136,7 @@ Future<void> testMain() async {
     } on TestFailure {
       return;
     }
-    throw TestFailure('transforms were too close to equal'); // ignore: only_throw_errors
+    throw TestFailure('transforms were too close to equal');
   }
 
   group('ui.Canvas clip tests', () {

engine/src/flutter/testing/dart/image_filter_test.dart

@@ -159,7 +159,6 @@ void main() async {
 
   List<ColorFilter> colorFilters() {
     // Create new color filter instances on each invocation.
-    // ignore: prefer_const_constructors
     return <ColorFilter>[
       ColorFilter.mode(green, BlendMode.color), // ignore: prefer_const_constructors
       ColorFilter.mode(red, BlendMode.color), // ignore: prefer_const_constructors

engine/src/flutter/testing/dart/spawn_test.dart

@@ -75,5 +75,5 @@ void main() {
     final Pointer<Utf8> fakePath = 'fake-path'.toNativeUtf8();
     expect(_loadLibraryFromKernel(fakePath), null);
     malloc.free(fakePath);
-  }, skip: kProfileMode || kReleaseMode); // ignore: avoid_redundant_argument_values
+  }, skip: kProfileMode || kReleaseMode);
 }

engine/src/flutter/tools/const_finder/test/fixtures/lib/consts.dart

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: prefer_const_constructors, unused_local_variable, depend_on_referenced_packages
+// ignore_for_file: prefer_const_constructors, unused_local_variable
 import 'dart:core';
 
 import 'package:const_finder_fixtures_package/package.dart';