Add various miscellaneous linter rulesets

Author: LiamPattinson

pyproject.toml

@@ -59,9 +59,19 @@ select = [
     "W", # pycodestyle warning
     "I", # isort
     "PT", # flake8-pytest-style
+    "B", # flake8-bugbear
+    "A", # flake8-builtins
+    "C4", # flake8-comprehensions
+    "EM", # flake8-errmsg
+    "T10", # flake8-debugger
+    "PTH", # flake8-use-pathlib
+    "SIM", # flake8-simplify
+    "TCH", # flake8-type-checking
     "UP", # pyupgrade
     "FURB", # refurb
+    "PERF", # perflint
     "RUF", # ruff specific
+    "NPY", # NumPy specific
 ]
 
 [tool.coverage.run]

src/pyloidal/cocos.py

@@ -34,15 +34,14 @@ class Sigma:
 
     def __post_init__(self):
         if self.B_poloidal not in (-1, 1):
-            raise ValueError(
-                f"B_poloidal should be either 1 or -1, found {self.B_poloidal}"
-            )
+            msg = f"B_poloidal should be either 1 or -1, found {self.B_poloidal}"
+            raise ValueError(msg)
         if self.r_phi_z not in (-1, 1):
-            raise ValueError(f"r_phi_z should be either 1 or -1, found {self.r_phi_z}")
+            msg = f"r_phi_z should be either 1 or -1, found {self.r_phi_z}"
+            raise ValueError(msg)
         if self.r_theta_phi not in (-1, 1):
-            raise ValueError(
-                f"r_theta_phi should be either 1 or -1, found {self.r_theta_phi}"
-            )
+            msg = f"r_theta_phi should be either 1 or -1, found {self.r_theta_phi}"
+            raise ValueError(msg)
 
 
 SIGMA_TO_COCOS = {

tests/test_cocos.py

@@ -17,12 +17,12 @@ def _identify_cocos_inputs(
 ) -> tuple[dict[str, Any], tuple[int, ...]]:
     """Generates inputs for ``identify_cocos`` for a given COCOS"""
     # Set up cocos 1 kwargs and modify accordingly
-    kwargs: dict[str, Any] = dict(
-        b_toroidal=2.5,
-        plasma_current=1e6,
-        poloidal_flux=np.linspace(0, 2, 3),
-        safety_factor=np.linspace(0.5, 1.5, 3),
-    )
+    kwargs: dict[str, Any] = {
+        "b_toroidal": 2.5,
+        "plasma_current": 1e6,
+        "poloidal_flux": np.linspace(0, 2, 3),
+        "safety_factor": np.linspace(0.5, 1.5, 3),
+    }
     expected: list[int] = [cocos]
 
     even_cocos = not bool(cocos % 2)