Incorporate effects from Animatrix

[davepl]

Feature

There are a number of interesting matrix effects to be found here:

https://github.com/StefanPetrick/animartrix/blob/main/animation_collection.ino

I think we should port some of the best ones to NightDriver. They would need to be wrapped in LEDStripEffect, and the oscillators likely need to go in GFXBase.

[robertlipe]

Be respectful of his license: https://github.com/StefanPetrick/animartrix#license

[davepl]

It's Creative Commons Attribution, the only license collision I can spot is non-commercial use, and we're non-commercial anyway. I doubt GPL3 is compatible with CCA, so likely not a good idea to use any of this code. But looking at the code, not stuff I'd want directly included as is because it's a big monolithic source file. Could be a good source of ideas for new effects, though.

[robertlipe]

Agreed on most points of that interpretation. Just wanted to call it out before anyone took "port" toooo literally. Look for mathematic inspiration.

(e.g. learn from https://fabiensanglard.net/doom_fire_psx/ - don't copy and paste from it.)

[davepl]

Agree 100%... my bad for not having read the CCA license more closely before making the suggestion. Appreciate you catching it!

[Bun-Bun]

This is something I would be interested in looking at. There are some neat effects in his library.

As far as the licensing goes, what is the best way to handle "learn from https://fabiensanglard.net/doom_fire_psx/ - don't copy and paste from it."? Do you give credit for inspiration in comments of the code?

[rbergen]

I'd say it is a matter of not copying/pasting any code, but be inspired by the mathematics used. The code will need to be structured to fit into this project's effect structure anyway.

[Bun-Bun]

Yes, I understand that. But does one give any credit where the inspiration for the mathematics came from? Or just silently take said inspiration?

[rbergen]

Personally I would give credit, and have done so in the past. There already are examples of source code comment credits within NightDriverStrip as well (case in point: PatternPongClock.h).

[Bun-Bun]

Perfect. That makes sense to me and will do the same.

[robertlipe]

I'm the author of the cited quotation. Yes, I'd give credit. Don't just do a mechanical transformation of the code. Math isn't copyrightable, though someone has surely tried. I think that most of the stuff in question is "just" math to do the actual transformations with the copyrightable, expressive parts (the expression in code and interfacing to the core of the project being the part mostly likely to need replaced. So don't write a translation layer, copy the files in question in, and declare victory. Golden rule still applies. People make their projects open source to share, but nobody likes being flagrantly ripped off. As disclosure, neither of the copyrights are mine. IANAL, but I am a s/w guy that's spent lots of time talking with lawyers about copyright issues through the years.

…

On Wed, May 31, 2023 at 9:15 AM Bun-Bun ***@***.***> wrote: Perfect. That makes sense to me and will do the same. — Reply to this email directly, view it on GitHub <#272 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCSD35P2FCPRKFHSZULIW3XI5G7LANCNFSM6AAAAAAYIFCQCY> . You are receiving this because you commented.Message ID: ***@***.***>

[Bun-Bun]

Thank you for that expansion of what you said. Makes sense to me.

I think the process of bringing the ideas over to this project (as davepl pointed out, it can't be directly included anyway due to the differing structure of the projects) as well as the process of learning and experimentation of the math/ideas would take care of any copyright issues.

Ethically it makes sense to me to give credit where inspirations came from. See it all the time in the music world but then you do see instances where some are still offended and seek legal action. My coding experience is all from a purely tinkering/hobbyist or 100% private business (ie. nothing shared publicly). Seeing others insights on the licensing aspect is valuable. Personally I'd be glad if someone learned something from my code and was inspired to create something the same or similar and would appreciate credit.

[netmindz]

If you use my fork https://github.com/netmindz/animartrix then it becomes trivial to wire the effects to different output formats, e.g https://github.com/netmindz/animartrix/blob/OO/examples/ANIMartRIX_FastLED/ANIMartRIX_FastLED.ino or https://github.com/MoonModules/WLED/blob/0562debbe1670fc72971d95da296cc9fb53f5f9a/usermods/usermod_v2_animartrix/usermod_v2_animartrix.h#L91

[robertlipe]

Nice! A lot of the work you've done is, indeed, the same work I'd mentally tagged when i was looking into doing this. Given my previous experience of porting patterns and having them accepted on one pass and rejected before landing in the trunk, I'll admit I lost interest in this project. To anyone else looking to cherry-pick specific effects, your branch is definitely closer to our primitives which holds up to reason given their histories. The basic models of frame building are just a better fit. Thanx for the tip.

…

On Sun, Jul 28, 2024 at 11:59 AM netmindz ***@***.***> wrote: If you use my fork https://github.com/netmindz/animartrix then it becomes trivial to wire the effects to different output formats, e.g https://github.com/netmindz/animartrix/blob/OO/examples/ANIMartRIX_FastLED/ANIMartRIX_FastLED.ino or https://github.com/MoonModules/WLED/blob/0562debbe1670fc72971d95da296cc9fb53f5f9a/usermods/usermod_v2_animartrix/usermod_v2_animartrix.h#L91 — Reply to this email directly, view it on GitHub <#272 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCSD374Q3UGUA7CWV26ULTZOUPQXAVCNFSM6AAAAABLS6MD4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGU4DANRUG4> . You are receiving this because you commented.Message ID: ***@***.***>