feat: [MC-690] Separate Pocket dev and prod JWK key ids (#361)

* feat: [MC-690] use different keys in Pocket-Dev

* chore: use --elv2-license accept in start:dev

* chore: fix lint errors in test

* wip: try to get test coverage for prod key ids

* fix: test for getSigningKeysFromServer mock env

* chore: clean up tests

* fix: lint errors

* fix: try to fix errors in Github superlinter

* fix: try to upgrade superlinter eslint

* fix: Failed to get [GITHUB_TOKEN]

* fix: lint error

* fix attempt: secret or public key must be provided

Possibly admin-api can't find the key id when it's not cached..?

Locally it works fine, but on Pocket-Dev the following error occurs for the same
request:

Context creation failed: Could not validate User: secret or public key must be provided

* fix: NODE_ENV should be development in Pocket-Dev

I pulled the latest image from Pocket-Dev and it's set to production
  # echo $NODE_ENV
  production

* fix: distinguish development (Pocket-Dev) from local dev

* chore: re-run checks

Required 'Lint Code Base' failed to run.

* fix: linter error

Author: mmiermans

.aws/src/main.ts

@@ -98,7 +98,7 @@ class AdminAPI extends TerraformStack {
         workspaces: {
           name: 'incident-management',
         },
-      }
+      },
     );
 
     return new PocketPagerDuty(this, 'pagerduty', {
@@ -147,7 +147,7 @@ class AdminAPI extends TerraformStack {
           ],
           envVars: [
             {
-              name: 'ENVIRONMENT',
+              name: 'NODE_ENV',
               value: process.env.NODE_ENV, // this gives us a nice lowercase production and development
             },
             {

.github/workflows/linter.yml

@@ -36,17 +36,21 @@ jobs:
       ##########################
       # Checkout the code base #
       ##########################
-      - name: Checkout Code
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          # super-linter needs the full git history to get the
+          # list of files that changed across commits
+          fetch-depth: 0
 
       ##########################
       # Github Super Linter needs
       # the latest definitions installed
       ##########################
-      - name: Use Node.js 16.x
-        uses: actions/setup-node@e33196f7422957bea03ed53f6fbb155025ffc7b8 # v3.7.0
+      - name: Use Node.js 18.x
+        uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
         with:
-          node-version: 16.x
+          node-version: 18.x
       # Install our eslint packages.
       # We may have custom tsconfigs, eslints that are brought in via a package.
       - run: npm install
@@ -55,12 +59,13 @@ jobs:
       # Run Linter against code base #
       ################################
       - name: Lint Code Base
-
-        # We use the Github super linter, it can be cranky at times, so in that moment here are the docs https://github.com/github/super-linter
-        uses: docker://ghcr.io/github/super-linter:slim-v4@sha256:80ecaa58ad5f9480c66e3c77af5c955831861a41fb78ce7e0ffb1b443eca0f0f
+        uses: super-linter/[email protected]  # x-release-please-version
 
         # All Environment variables are defined here https://github.com/github/super-linter#environment-variables
         env:
+          # To report GitHub Actions status checks
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
           # The name of the repository default branch.
           DEFAULT_BRANCH: main