Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdapterManager support is not currently available in dynamic graphs #287

Closed
Roh-codeur opened this issue Jun 19, 2024 · 4 comments
Closed
Labels
adapter: general Issues and PRs related to input/output adapters in general tag: question Questions about use, potential features, or improvements type: feature Issues and PRs related to new features

Comments

@Roh-codeur
Copy link

Hi

I have been using this package. truly amazing, also thanks for the docs

Is your feature request related to a problem? Please describe.

  1. I am setting up a graph which sources in tickers from a source
  2. Depending on the ticker, I subscribe to market data (via adapter)
  3. I am using a Dynamic graph. this graph has a node which gives me the node
  4. When the graph gets a ticker, I create a graph(to be included in Dynamic Graph) which uses Adapter Manager to create a market data subscription
  5. At this point, I get the below error:

NotImplementedError: AdapterManager.cpp:AdapterManager:19:NotImplemented: AdapterManager support is not currently available in dynamic graphs

Describe the solution you'd like
Is there some way we can support AdapterManager in DynamicGraphManager please?

Describe alternatives you've considered
Actually, it's a bit tricky to get data from a db/messaging bus without an AdapterManager - can you please suggest an alternate solution pls?

ta!

@timkpaine
Copy link
Member

This is somewhat related to #277, as we need to enhance our adapter to have a pattern where dynamic subscriptions are more native. Right now most adapters expect all connections to be resolved at graph-building-time, and this is a pretty unrealistic expectation as your example plainly illustrates.

Will leave this open as separately, adapters should support dynamic regardless of #277.

@timkpaine timkpaine added type: feature Issues and PRs related to new features adapter: general Issues and PRs related to input/output adapters in general labels Jun 19, 2024
@Roh-codeur
Copy link
Author

got it, I understand. in the meantime, Can you suggest a workaround for this please? ta!

@robambalu
Copy link
Collaborator

At this point in time you would need to know your ticker universe up front, or "over subscribe" to all possible tickers.

@timkpaine timkpaine closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2024
@timkpaine timkpaine added the tag: question Questions about use, potential features, or improvements label Jun 20, 2024
@Roh-codeur
Copy link
Author

thanks for looking into this. this is an excellent library - thanks for making it open source. This functionality is quite essential to my current project, I will keep an eye for this when it's a part of the library. ta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapter: general Issues and PRs related to input/output adapters in general tag: question Questions about use, potential features, or improvements type: feature Issues and PRs related to new features
Projects
None yet
Development

No branches or pull requests

3 participants