Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util shared lib for windows #454

Open
alexddobkin opened this issue Feb 21, 2025 · 0 comments
Open

util shared lib for windows #454

alexddobkin opened this issue Feb 21, 2025 · 0 comments
Labels
adapter: general Issues and PRs related to input/output adapters in general lang: c++ Issues and PRs related to the C++ codebase part: build Issues and PRs related to the build process

Comments

@alexddobkin
Copy link
Collaborator

Need to properly dllexport / dllimport utils lib so that we can build shared lib for windows. Without that, if anyone builds an adapter and tries to link with util lib on windows, and invoke a call to absl with a different version, it won't work.
@alexddobkin alexddobkin mentioned this issue Feb 21, 2025
Merged
@timkpaine timkpaine added lang: c++ Issues and PRs related to the C++ codebase adapter: general Issues and PRs related to input/output adapters in general part: build Issues and PRs related to the build process labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adapter: general Issues and PRs related to input/output adapters in general lang: c++ Issues and PRs related to the C++ codebase part: build Issues and PRs related to the build process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timkpaine @alexddobkin