Skip to content

Commit 518dc86

Browse files
committed
fix: Properly type userProperties/groupProperties
1 parent f7ae8a9 commit 518dc86

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

posthog-server/src/main/java/com/posthog/server/internal/PostHogFeatureFlags.kt

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ internal class PostHogFeatureFlags(
9696
key: String,
9797
distinctId: String,
9898
groups: Map<String, String>?,
99-
personProperties: Map<String, String>?,
100-
groupProperties: Map<String, String>?,
99+
personProperties: Map<String, Any?>?,
100+
groupProperties: Map<String, Map<String, Any?>>?,
101101
): FeatureFlag? {
102102
val cachedFlags =
103103
getFeatureFlagsFromCache(distinctId, groups, personProperties, groupProperties)
@@ -157,8 +157,8 @@ internal class PostHogFeatureFlags(
157157
private fun getFeatureFlagsFromCache(
158158
distinctId: String,
159159
groups: Map<String, String>?,
160-
personProperties: Map<String, String>?,
161-
groupProperties: Map<String, String>?,
160+
personProperties: Map<String, Any?>?,
161+
groupProperties: Map<String, Map<String, Any?>>?,
162162
): Map<String, FeatureFlag>? {
163163
val cacheKey =
164164
FeatureFlagCacheKey(
@@ -174,8 +174,8 @@ internal class PostHogFeatureFlags(
174174
private fun getFeatureFlagsFromLocalEvaluation(
175175
distinctId: String,
176176
groups: Map<String, String>?,
177-
personProperties: Map<String, String>?,
178-
groupProperties: Map<String, String>?,
177+
personProperties: Map<String, Any?>?,
178+
groupProperties: Map<String, Map<String, Any?>>?,
179179
onlyEvaluateLocally: Boolean = false,
180180
): Map<String, FeatureFlag>? {
181181
if (!localEvaluation) {
@@ -225,8 +225,8 @@ internal class PostHogFeatureFlags(
225225
private fun getFeatureFlagsFromRemote(
226226
distinctId: String,
227227
groups: Map<String, String>?,
228-
personProperties: Map<String, String>?,
229-
groupProperties: Map<String, String>?,
228+
personProperties: Map<String, Any?>?,
229+
groupProperties: Map<String, Map<String, Any?>>?,
230230
): Map<String, FeatureFlag>? {
231231
val cacheKey =
232232
FeatureFlagCacheKey(
@@ -411,9 +411,9 @@ internal class PostHogFeatureFlags(
411411
private fun computeFlagLocally(
412412
key: String,
413413
distinctId: String,
414-
personProperties: Map<String, Any?>,
415414
groups: Map<String, String>?,
416-
groupProperties: Map<String, String>?,
415+
personProperties: Map<String, Any?>?,
416+
groupProperties: Map<String, Map<String, Any?>>?,
417417
): Any? {
418418
val flags = this.flagDefinitions ?: return null
419419
val flag = flags[key] ?: return null

posthog-server/src/test/java/com/posthog/server/internal/PostHogFeatureFlagsTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ internal class PostHogFeatureFlagsTest {
457457
defaultValue = false,
458458
distinctId = "user-123",
459459
groups = mapOf("organization" to "org-456"),
460-
groupProperties = mapOf("plan" to "enterprise"),
460+
groupProperties = mapOf("org-456" to mapOf("plan" to "enterprise")),
461461
)
462462

463463
// Debug logging

0 commit comments

Comments
 (0)