-
Notifications
You must be signed in to change notification settings - Fork 197
feat: session recording tracks previous and next session id #2503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
73067fb to
e7b03ee
Compare
|
Size Change: +490 B (+0.01%) Total Size: 4.87 MB
ℹ️ View Unchanged
|
e7b03ee to
00a0fbd
Compare
cafdfbd to
fa2e313
Compare
fa2e313 to
edc24cb
Compare
| private _onSessionIdCallback: SessionIdChangedCallback = (sessionId, windowId, changeReason) => { | ||
| if (changeReason) { | ||
| this._tryAddCustomEvent('$session_id_change', { sessionId, windowId, changeReason }) | ||
| if (!changeReason) return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a follow-up here... i know why we'd ignore part of this for no change reason.
but maybe we shouldn't ignore all of it 🤔
edc24cb to
705452e
Compare
705452e to
ab2c819
Compare
ab2c819 to
dd6b0ab
Compare

when watching a session it might end because a user went idle, but to the user they're just picking up after a long gap
let's track previous and next session, so we can let watchers navigate backwards and forwards in the UI
we could look up this data but it's relatively slow to query and we can just store it in the SDK instead
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file