Skip to content

Commit 1d8b0f1

Browse files
committed
fix: Avoid return from finally: block
This fixes a SyntaxWarning on Python 3.14. ``` ❯ uvx --no-cache --python 3.14.0 --with posthog==6.7.11 python -c "import posthog" Installed 11 packages in 5ms .../lib/python3.14/site-packages/posthog/consumer.py:92: SyntaxWarning: 'return' in a 'finally' block return success ````
1 parent a155e1d commit 1d8b0f1

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

posthog/consumer.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,8 @@ def upload(self):
8989
# mark items as acknowledged from queue
9090
for item in batch:
9191
self.queue.task_done()
92-
return success
92+
93+
return success
9394

9495
def next(self):
9596
"""Return the next batch of items to upload."""

0 commit comments

Comments
 (0)