Bugfix for ContainerRegistry repository to parse out dependencies from metadata - #1766
Merged
Anam Navied (anamnavi) merged 3 commits intoJan 7, 2025
Merged
Conversation
Aditya Patwardhan (adityapatwardhan)
approved these changes
Dec 20, 2024
alerickson
approved these changes
Dec 27, 2024
Member
|
We should add a test to for this (manually adding the Az module to the 'psresourcegettest' ACR instance) |
Anam Navied (anamnavi)
deleted the
bugfix-containerregistry-dependencies
branch
January 7, 2025 16:44
Anam Navied (anamnavi)
added a commit
that referenced
this pull request
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
For ContainerRegistry repositories, we currently check for dependencies from
RequiredModulesandPrivateData.ModuleListbut Az modules will have it inModuleListelement not within PrivateData.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.