add codeql suppression and explanation (#670)

tgauth · web-flow · commit cdee73645a2c · 2023-03-20T13:59:39.000-04:00
diff --git a/ssh-sk.c b/ssh-sk.c
@@ -133,7 +133,7 @@ sshsk_open(const char *path)
 		goto fail;
 #endif
 	}
-	if ((ret->dlhandle = dlopen(path, RTLD_NOW)) == NULL) {
+	if ((ret->dlhandle = dlopen(path, RTLD_NOW)) == NULL) { // CodeQL [SM01925]: upstream code that permits user input to specify external provider is by design, but only accessible via CLI parameter
 		error("Provider \"%s\" dlopen failed: %s", path, dlerror());
 		goto fail;
 	}

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ sshsk_open(const char *path)`
`133`	`133`	`goto fail;`
`134`	`134`	`#endif`
`135`	`135`	`}`
`136`		`- if ((ret->dlhandle = dlopen(path, RTLD_NOW)) == NULL) {`
	`136`	`+ if ((ret->dlhandle = dlopen(path, RTLD_NOW)) == NULL) { // CodeQL [SM01925]: upstream code that permits user input to specify external provider is by design, but only accessible via CLI parameter`
`137`	`137`	`error("Provider \"%s\" dlopen failed: %s", path, dlerror());`
`138`	`138`	`goto fail;`
`139`	`139`	`}`