-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: F-Droid can't build #725
Comments
This issue is very strange. We indeed synchronized the git submodules before releasing the new version. Currently, flutter is at commit 35c388afb57ef061d06a39b537336c87e0e3d1b1, which is the same as the stable branch in the official flutter repository. Our build script outputs the SDK version during the build, and both Gitlab CI and GitHub Actions report version 3.29.0. What do you think about this issue? Should we try using srclib instead? |
I really don't know how this happened. Since commit id is the same I don't think using srclib can solve this problem, there should be some other reasons |
Seems that 1.5.6 build failed too. I can't find it on F-Droid. Could we get the build logs for version 1.5.6? That way, we can see what happened and whether it's related to the current error. |
1.5.6 built fine, will be published soon: https://monitor.f-droid.org/builds/log/com.predidit.kazumi/105062#site-footer and the CI at update time: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/19393/pipelines |
I think maybe it's related to flutter monorepo. Seems that flutter don't have independent flutter/engine repo any more since 3.28 beta. Let's try using srclib as part of our debugging process. |
https://gitlab.com/fdroid/fdroiddata/-/jobs/9141863246#L6313 @Predidit I think this is a flutter side issue |
from a chat with @linsui how about we use submodules BUT instead of using the CI provided Flutter you use the submodule Flutter to build too? |
here: https://github.com/Predidit/Kazumi/blob/main/.github/workflows/release.yaml#L52 use: |
I don't think this approach is appropriate, as it contradicts the purpose of the fastlane folder. In my view, the files in fastlane should only affect Android builds, and this could lead to discrepancies between GitHub CI and our development environment. I am trying to track down the origin of libflutter.so—it appears to be a prebuilt binary from Google. |
I've suggested this operation here. but we've tried using submodule and srclib in metadata and both failed, I think it will not make any difference |
When we run flutter from the flutter repo, it should automatically fetch the flutter package with corresponding version. But it fetches a wrong version for flutter 3.29.0. I'm not sure why this happens yet. |
We should be able to retrieve detailed information about the Flutter version currently in use within GitLab CI, just like this. https://github.com/Predidit/Kazumi/actions/runs/13331237800/job/37235617435 |
who forces you to put something in the fastlane folder? not sure I follow 😄 as said, we need both CIs, yours and ours, to run with the same Flutter, and the best way is to run from the folder that you control not F-Droid srclib, nor Github image random version |
In flutter repo, branch stable's commit was completely changed when 3.29.0 is released. I cannot simply use git pull to update my local environment. Don't know what happened to it. Though I think it's not the reason. |
The problem is that running flutter from https://github.com/flutter/flutter somehow doesn't get the correct version. I doubt that google messed up it somehow. And I just found that the file used to keep the version of the engine was added to gitignore in flutter/flutter@721b47e. Not sure if this is related. |
We checkout to 3.29.0 here https://gitlab.com/fdroid/fdroiddata/-/jobs/9141863246#L756 Github action also checkout repo in this script And this is the 3.29.0 tag ![]() Just weird. |
I thought this is an upstream bug so I created flutter/flutter#163308. |
I will migrate to submodules in Github Actions. But I think it's an error from flutter team. Maybe we can open a issue. |
subosito/flutter-action only checkout to 3.29.0 tag when channel has been set to master I think it makes difference. subosito/flutter-action using stable branch rather than tag 3.29.0 on master branch. |
Looks like flutter team messed up something when cherry_picking, just take a look at the commit history in branch stable. And we were using this action in a wrong way all the time. |
I don't think we are using the action in wrong way. Indeed, branch stable has the same binary with our local environment, and newer flutter engine. Tag 3.29.0 on branch stable should same with branch master. But seems that Google broken that. If we migrate to tag 3.29.0, we will get outdated flutter engine in github actions. |
no, I mean we used with and I need to draw another PR to fix subosito/flutter-action#334 update: yes you are right, |
flutter/flutter#163198 (comment) It seems that checkout to flutter/flutter@f73bfc4 can be a workaround. but I don't know how to achieve this right now since we have pushed some commits to repo that will break libapp.so |
In my view, if we want to fix 1.5.7 build. We need srclib and check out to correct commit. (of course, we will migrate back to submodules in kazumi 1.5.8) Tag 1.5.7 on kazumi repo has pin flutter submodules to wrong commit. I think flutter team may re-tag 3.29.0 on branch master. If they do that. We need update git submodules, and it will not affect tag 1.5.7 on kazumi repo. I really don't want to re-tag 1.5.7. We have serval commits since 1.5.7. |
We can skip 1.5.7 and wait for the flutter fix. :) |
Will follow the Flutter fix |
在使用的时候发生了什么 Bug ?
sounds like the Flutter version used to build your APK does not match the one in the submodule
ref: https://gitlab.com/fdroid/checkupdates-bot-fdroiddata/-/jobs/9137318111#L6266
您在使用哪个操作系统?
Android
请具体提供设备、版本号等信息。
(选填)一些与 Bug 相关的硬件信息。
No response
日志信息
提交前确认
The text was updated successfully, but these errors were encountered: