Stop resolve_path defaulting to random UUID if path is "" (#212)

Author: ahuang11

CHANGELOG.md

@@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Fixed errors raised when using `write_path` and `read_path` with `credentials` field on `S3Bucket` - [#208](https://github.com/PrefectHQ/prefect-aws/pull/208)
+- Resolving paths in `S3Bucket` unintentionally generating an arbitrary UUID when path is an empty string - [#212](https://github.com/PrefectHQ/prefect-gcp/pull/212)
 
 ## 0.2.4
 

prefect_aws/s3.py

@@ -6,7 +6,6 @@
 import warnings
 from pathlib import Path, PurePath
 from typing import Any, BinaryIO, Dict, List, Optional, Union
-from uuid import uuid4
 
 import boto3
 from botocore.paginate import PageIterator
@@ -402,9 +401,6 @@ def _resolve_path(self, path: str) -> str:
                 bucket has a unique key (or key name).
 
         """
-
-        path = path or str(uuid4())
-
         bucket_folder = self.bucket_folder or self.basepath
         # If basepath provided, it means we won't write to the root dir of
         # the bucket. So we need to add it on the front of the path.

tests/test_s3.py

@@ -594,6 +594,10 @@ def test_deployment_set_basepath(aws_creds_block, type_):
     assert deployment.location == "home/"
 
 
+def test_resolve_path(s3_bucket):
+    assert s3_bucket._resolve_path("") == ""
+
+
 class TestS3Bucket:
     @pytest.fixture(
         params=[