Skip to content

Incorrectly using "incorrect_for_wooden_tool" material tag in some blocks in BlocksData since 1.20.5 #52

@guss-alberto

Description

@guss-alberto

The current implementation, when more than one material is found, simply picks the first one and and logs an error with the remaining ones, however since 1.20.5 tags such as incorrect_for_wooden_tool incorrect_for_gold_tool etc have been added. The current implementation however seems to always pick incorrect_for_wooden_tool when present, because it's the first one.

This is incorrect, as it should use the mineable/<tool> material, the correct tools are already included in the "harvestTools" json prop, ultimately causing really long block breaking times in mineflayer for anything that is tagged incorrect_for_wooden_tool.

It should check for the "mineable/" prefix and only fall back to picking the first one if there is no other tag present.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions