Clarification of the blockCollisionShape data

[ItsDrike]

Hey, I'd just like some clarification on the meaning of the blockCollisionShape data. From the schema, I see that shapes seem to contain a bunch of collision boxes for the given block, stating a description of: The min/max x/y/z corner coordinates of this box., with it containing 6 numbers.

However, there's no clear description that would better explain how to interpret these 6 numbers. I would assume that it's something like: (min_x, min_y, min_z, max_x, max_y, max_z), or perhaps (min_x, max_x, min_y, max_y, min_z, max_z). however, if this is the case, I'd expect the min value to always be smaller than the max value for given coordinate. And yet, neither of these structures holds up to that check in all supported versions.

Would you mind explaining what the 6 numbers in the collision shape actually mean?

[extremeheat]

They're the (x0, y0, z0, x1, y1, z1) points of an axis aligned bounding box (AABB).

They should be the min/max, and it's directly as stored by the game. Relevant part of data generator is https://github.com/PrismarineJS/minecraft-data-generator/blob/main/mc/1.21.5/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlockCollisionShapesDataGenerator.java#L92

[ItsDrike]

Hmm, interesting, that's what I thought initially, but when interpreting them as (min_x, min_y, min_z, max_x, max_y, max_z), the data violates the constraint of min <= max for several entries (interestingly enough, only for some bedrock editions though, all java editions pass this check and some bedrock editions do too).

The following editions contain block collision shape data that do not meet this check:

• bedrock/1.17.0 (446 violations)
• bedrock/1.20.0 (468 violations)
• bedrock/1.20.10 (468 violations)
• bedrock/1.20.15 (468 violations)
• bedrock/1.20.30 (468 violations)
• bedrock/1.20.40 (468 violations)
• bedrock/1.20.50 (469 violations)
• bedrock/1.20.61 (469 violations)
• bedrock/1.20.71 (469 violations)
• bedrock/1.20.80 (469 violations)
• bedrock/1.21.0 (469 violations)
• bedrock/1.21.2 (469 violations)
• bedrock/1.21.20 (469 violations)
• bedrock/1.21.30 (469 violations)
• bedrock/1.21.42 (469 violations)
• bedrock/1.21.50 (469 violations)
• bedrock/1.21.60 (469 violations)
• bedrock/1.21.70 (469 violations)
• bedrock/1.21.80 (469 violations)
• bedrock/1.21.90 (469 violations)
• bedrock/1.21.93 (469 violations)
• bedrock/1.21.100 (469 violations)

One concrete example in the data is here for example:

https://github.com/PrismarineJS/minecraft-data/blob/c7509e277a28753663e5f48433f146eb17773f0d/data/bedrock/1.17.0/blockCollisionShapes.json#L2982C3-L2982C18

Notice the second array: [0.90625, 0.5, 0.5, 0.1875, 0.625, 0.625], with the min_x of 0.90625 and max_x of 0.1875, violating min_x <= max_x

[ItsDrike]

Would it be safe to just update the data and flip these numbers to make them follow this format properly? Is there some reason they don't already follow it?