Skip to content

Commit e3c4dbc

Browse files
authored
Merge pull request #3862 from ProcessMaker/feature/FOUR-3612
FOUR-3612: Review and improve sql query request_user_permissions
2 parents a8ce730 + b10e977 commit e3c4dbc

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

ProcessMaker/Models/User.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -377,10 +377,13 @@ public function canSelfServe(ProcessRequestToken $task)
377377
public function updatePermissionsToRequests()
378378
{
379379
// Update existing request_user_permissions
380-
$permissions = RequestUserPermission::with('request')->whereHas('request', function ($query) {
381-
$query->where('request_user_permissions.user_id', $this->getKey());
382-
$query->whereRaw('process_requests.updated_at > request_user_permissions.updated_at');
383-
})->get();
380+
$permissions = RequestUserPermission::with('request')
381+
->select('request_user_permissions.*')
382+
->leftJoin('process_requests', 'request_user_permissions.request_id', '=', 'process_requests.id')
383+
->where('request_user_permissions.user_id', $this->getKey())
384+
->whereRaw('process_requests.updated_at > request_user_permissions.updated_at')
385+
->get();
386+
384387
foreach ($permissions as $permission) {
385388
$permission->can_view = $this->can('view', $permission->request);
386389
$permission->save();

0 commit comments

Comments
 (0)